Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent confusion with the commercial plugin #1

Closed
Stephan202 opened this issue Nov 28, 2015 · 10 comments
Closed

Prevent confusion with the commercial plugin #1

Stephan202 opened this issue Nov 28, 2015 · 10 comments

Comments

@Stephan202
Copy link

I just dropped sonar-swift-plugin-0.1.jar into our SonarQube 5.2 installation. It's recognized just fine, quality profiles and rules and all, which is nice :). (Can't give feedback on analysis results yet; I'm not involved in Swift development in our company, and I haven't communicated yet that I installed this plugin.)

But when I go to the Update Center, it suggests that I upgrade the plugin from version 0.1 to 1.5, with a link to the home page and release notes of the commercially available/official Swift plugin. That's quite confusing, and probably not what you want. :)

@zippy1978
Copy link
Contributor

Thank you @Stephan202 !

I forgot to check that...
I will fix it in the next release.

Gilles

@giacgbj
Copy link

giacgbj commented Dec 22, 2015

👍

@giacgbj
Copy link

giacgbj commented Feb 12, 2016

Is there a reason you don't close this ticket?
It's the fourth release after the "next release".

It's not only a matter of confusion regarding the aforementioned information: if you automatically update your plugin, the downloaded file is actually https://sonarsource.bintray.com/CommercialDistribution/sonar-swift/sonar-swift-plugin-1.5.1.jar (from http://www.sonarsource.com/products/plugins/languages/swift/).

The result is that you wipe out your plugin and install the commercial one! :-)

@zippy1978
Copy link
Contributor

Hi
I know... But I did not manage to find on which id/property of the plugin the Update Center relies on yet...

@rompic
Copy link

rompic commented Feb 14, 2016

octo-technology/sonar-objective-c#88

There was a similar Problem with sonar objective-c

@zippy1978
Copy link
Contributor

Ok,

So, I just need to change the language key and few other things.
But I don't know what key to use yet.... "swift" was good :), anything else will not be as readable / understandable...

Your ideas are welcomed !

@rompic
Copy link

rompic commented Feb 15, 2016

swift-ce ?

@gretzki
Copy link
Contributor

gretzki commented Feb 24, 2016

swiftos (for open source),
swifty,
swifflemanizzle

You're welcome! ;P

@zippy1978
Copy link
Contributor

Hi,

I changed everything as detailed in PR octo-technology/sonar-objective-c#88.

But still the confusion remains in the update center....

Any ideas ?

@zippy1978
Copy link
Contributor

Finally fixed !
And I did not have to change language key.

It is available in release 0.2.2

vexdev pushed a commit to vexdev/sonar-swift that referenced this issue Oct 9, 2017
…aster

* commit '1702d264a3aed8792cacda9d11c8a94bc2f4972d':
  Moved the project to gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants