Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfdata with dot in label splits into separate folders #210

Open
log1-c opened this issue May 24, 2019 · 2 comments
Open

Perfdata with dot in label splits into separate folders #210

log1-c opened this issue May 24, 2019 · 2 comments
Labels
area/backend Affects the graphite backend

Comments

@log1-c
Copy link
Contributor

log1-c commented May 24, 2019

Some checks don't display graphs for the perf data they collect.
Here is one example:
image

The label name has a dot in the name (blabla_backup.bak size).

The normal behavior is that special characters and spaces are replaced by an underscore when creating the folder structure.
When there is a dot in the perf data label this does not seem to work, as I get the following folder structure for this check:
/var/lib/graphite/whisper/icinga2/HOSTNAME/services/SERVICENAME/CHECKCOMMAND/perfdata/PART-BEFORE-THE-DOT/PART-AFTER-THE-DOT/*.wsp files

e.g. for the screenshot above
/var/lib/graphite/whisper/icinga2/HOSTNAME/services/file_size_Tibros_172_backup/nrpe/perfdata/tibros172_backup/bak_size/value.wsp
-----^^^^------ ^^^^

Best regards,
log1c

@Al2Klimov
Copy link
Member

@dnsmichi What about also escaping . in Icinga 2? We already have :: for multi levels.

@Al2Klimov Al2Klimov added the needs-feedback We'll only proceed once we hear from you again label Aug 13, 2019
@dnsmichi
Copy link
Contributor

That was requested in the past as feature, followed by a strong discussion to allow people control their depth in check plugins. This resulted in a changed Graphite schema in 2.4 - Icinga/icinga2#2474

Changing the schema behaviour again is a no-no.

@dnsmichi dnsmichi removed their assignment Aug 13, 2019
@dnsmichi dnsmichi removed the needs-feedback We'll only proceed once we hear from you again label Aug 13, 2019
@dnsmichi dnsmichi added the area/backend Affects the graphite backend label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Affects the graphite backend
Projects
None yet
Development

No branches or pull requests

3 participants