Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restriction and url migration #932

Closed
nilmerg opened this issue Oct 23, 2023 · 0 comments · Fixed by #929
Closed

Restriction and url migration #932

nilmerg opened this issue Oct 23, 2023 · 0 comments · Fixed by #929
Assignees
Labels
area/configuration Affects the configuration enhancement New feature or improvement
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Oct 23, 2023

Is your feature request related to a problem? Please describe.

There are various places in Icinga Web where urls or filters of specific products are referenced. One such product is the monitoring module as well as Icinga DB Web.

The various places

  • Dashboards
  • Navigation Items
  • Restrictions

The Problem

Users may have plenty of custom dashboards, navigation items as well as plenty of roles with restrictions. They either reference specific monitoring urls with filters or icingadb urls with wildcards in filters which still use the equal/unequal operators.

Dashboards

  • No url migration

Users have no automated way of migrating dashboard urls at the moment.

Navigation Items

  • Possibly no wildcard filter migration

While navigation items can already be migrated by using icingacli migrate navigation, we have to verify that wildcard filters are also migrated.

Restrictions

  • No filter migration at all

Users have no automated way of migrating monitoring restrictions to icingadb and icingadb wildcard filters.

Describe the solution you'd like

Dashboards
There should be a new command icingacli migrate monitoring-dashboards (Why monitoring-? Because I don't want to waste the dashboards command), which migrates monitoring-dasboard-urls to their new icingadb counterparts.
There should be a new command icingacli migrate icingadb-dashboards which migrates icingadb-dashboard-urls which use the old wildcard filter syntax.

Navigation Items
Users who already ran the migration in the past, should be able to run it again to migrate the wildcard filters.

Restrictions
There should be a new command icingacli migrate monitoring-restrictions which migrates monitoring restrictions to their new icingadb counterparts.
There should be a new command icingacli migrate icingadb-restrictions which migrates icingadb restrictions which use the old wildcard filter syntax.

Additional context

The migration of urls and filters is already possible by using Icinga\Module\Icingadb\Compat\UrlMigrator. The only thing that needs to be implemented are the commands and the configuration handling.

@nilmerg nilmerg added enhancement New feature or improvement area/configuration Affects the configuration labels Oct 23, 2023
@nilmerg nilmerg linked a pull request Oct 26, 2023 that will close this issue
@nilmerg nilmerg transferred this issue from Icinga/icingaweb2 Nov 10, 2023
@nilmerg nilmerg changed the title Icinga DB Web restriction and url migration Restriction and url migration Nov 10, 2023
@nilmerg nilmerg added this to the 1.1.1 milestone Nov 10, 2023
@nilmerg nilmerg linked a pull request Nov 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Affects the configuration enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants