Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from first-use #1

Open
wvangeit opened this issue May 23, 2024 · 0 comments
Open

Comments from first-use #1

wvangeit opened this issue May 23, 2024 · 0 comments

Comments

@wvangeit
Copy link

wvangeit commented May 23, 2024

Just some remarks, based on first use of the repo:

  • it's not clear where the 'Usage' code has to run. I e.g. created a new src directory called test-service, but then the script created a subdirectory inside of it called test_service.
  • when running run-local I'm getting (nonblocking failure)
sh: 2: -c: not found
  • i would remove most of the logs generated by that run/execute script, to make things cleaner during runtime, the user won't know what these things mean
  • it's not clear from the doc where the user can specify the command to be execute (should be part of 'Usage' imo)
  • maybe you can create a 'quick start' section that goes through an entire example
  • tiny detail, i would call the 'run' script 'run.sh'
  • it's not clear at all how the inputs/outputs are handled (how does one access the input files from the command given in the string)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant