Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/Idea: 'Sticky' dataset file filtering #9917

Closed
kuhlaid opened this issue Sep 14, 2023 · 6 comments
Closed

Feature Request/Idea: 'Sticky' dataset file filtering #9917

kuhlaid opened this issue Sep 14, 2023 · 6 comments
Labels
Feature: File Upload & Handling Type: Bug a defect User Role: Guest Anyone using the system, even without an account

Comments

@kuhlaid
Copy link
Contributor

kuhlaid commented Sep 14, 2023

What kind of user is the feature intended for?
Everyone

What inspired the request?
Trying to filter a dataset but keep getting redirected to the top of the page and needing to scroll back down to the files.

What existing behavior do you want changed?
When a file filter is applied, for example if a user selects a different file type, file tag or even the file sorting option, this refreshes the page with the filtered content. The problem is that it sends the user back to the top of the page and thus loses focus on the file list, so the user if forced to scroll back down to the bottom of the page where the files are located. Ideally the file list would retain focus when filters selections changed by a user.

Any brand new behavior do you want to add to Dataverse?
One option would be to add an anchor tag at the dataset 'tabs' (Files, Metadata, Terms, Version) and when a filter is applied, the URL will include the anchor so that the page refresh keeps the files in focus (see screenshot below of the dataset tabs I am referring to). If the file list can be refreshed without redrawing the entire HTML page that would work as well but it depends on how you are choosing to handle content changes on a page.

image

@pdurbin
Copy link
Member

pdurbin commented Sep 15, 2023

@kuhlaid yeah, I agree this is pretty annoying! For now I'll say that we're working on this in the new frontend:

I'll try to remember to let you know when that PR has been merged and the code deployed to the beta server.

@pdurbin pdurbin added Feature: File Upload & Handling Type: Bug a defect User Role: Guest Anyone using the system, even without an account labels Oct 13, 2023
@DS-INRAE DS-INRAE moved this to 🔍 Interest in Recherche Data Gouv Nov 19, 2024
@DS-INRAE
Copy link
Member

@pdurbin Should this issue have an SPA related tag so it is visible in order to address it then :) ?

@pdurbin
Copy link
Member

pdurbin commented Nov 19, 2024

@DS-INRAE well, above it looks like I was trying to say that I'd let you and @kuhlaid know when the pull request above has been merged and deployed to https://beta.dataverse.org

Can you reproduce the issue there on the beta server?

@kuhlaid
Copy link
Contributor Author

kuhlaid commented Nov 19, 2024

It is still a problem on beta site. If you are on the dataset page under Table View and you choose a different File Tag (on page https://beta.dataverse.org/dataset.xhtml?persistentId=doi%3A10.5072%2FFK2%2FK8E7PV&version=&q=&fileTypeGroupFacet=%22Tabular+Data%22&fileAccess=&fileTag=%22Data%22&fileSortField=&fileSortOrder=&tagPresort=true&folderPresort=true for example), the page refreshes and takes you back to the top of the page. Maybe simply use anchor tags in the URL (e.g. #tabs to pull the focus back down to the tabbed section). Thank you.

@pdurbin
Copy link
Member

pdurbin commented Nov 19, 2024

@kuhlaid thanks, would you be willing to create an issue at https://github.com/IQSS/dataverse-frontend about this?

@kuhlaid
Copy link
Contributor Author

kuhlaid commented Nov 19, 2024

@pdurbin IQSS/dataverse-frontend#552

@kuhlaid kuhlaid closed this as completed Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 🔍 Interest to Done in Recherche Data Gouv Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Bug a defect User Role: Guest Anyone using the system, even without an account
Projects
Status: Done
Development

No branches or pull requests

3 participants