Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation to decide if displayoncreate is true or false for metadata fields #6561

Closed
vbernabe opened this issue Jan 23, 2020 · 17 comments
Labels
Feature: Metadata Type: Suggestion an idea User Role: Curator Curates and reviews datasets, manages permissions

Comments

@vbernabe
Copy link

Bug Report: Optional Metadata not showing on Dataset Form
Dataverse version: 4.18.1
Glassfish: 4.1

I am trying to update the Metadata to include optional field such as grant information but this is not showing up on the Create Dataset form.
Steps:

  1. Update Citation Metadata of Dataverse -> set grant information as optional field
    image
  2. Create a Dataset - it should show the grant information field without *
    Issue below: grant field not showing
    image

If I set the Metadata to Required though it will show up in the form.
Steps:

  1. Update Citation Metadata of Dataverse -> set grant information as required field
    image
  2. Create a Dataset - it should show the grant information field with *. Correctly shown on form
    image
@pdurbin
Copy link
Member

pdurbin commented Jan 23, 2020

@vbernabe hi! This is controlled by the "displayoncreate" boolean.

"Designate fields that should display during the creation of a new dataset, even before the dataset is saved. Fields not so designated will not be displayed until the dataset has been saved."

Please see http://guides.dataverse.org/en/4.18.1/admin/metadatacustomization.html#datasetfield-field-properties

Here's a screenshot of that part of the doc.

Screenshot from 2020-01-23 07-29-07

You can find the "displayoncreate" column here: https://github.com/IQSS/dataverse/blob/v4.18.1/scripts/api/data/metadatablocks/citation.tsv#L3

I hope this helps!

@djbrooke
Copy link
Contributor

Hi @vbernabe, I'll close this out since it appears to be answered but please let us know in a comment if there are any other questions.

Thanks @pdurbin !

@vbernabe
Copy link
Author

vbernabe commented Jan 24, 2020

Hi @pdurbin and @djbrooke, Thanks for your quick response.

Is there a way to distinguish if a field is set as "optional" and can be viewed on creation of new dataset or if it will only be displayed after creation of a dataset? This is to avoid confusion, similar fields like - keyword, related publication, notes are showing even if it is set as optional but other fields set as optional for instance on this sample - grant information is not showing up.

Or maybe we can also include on the documentation that updating metadata blocks shipped with Dataverse will not automatically be shown to the creation of new dataset? I was thinking that I don't need to do custom metadata and can customize based on Dataverse web interface as suggested on the introduction of the documentation http://guides.dataverse.org/en/4.18.1/admin/metadatacustomization.html#id14

For now though I will do custom metadata update as you suggested :)

@pdurbin
Copy link
Member

pdurbin commented Jan 24, 2020

@vbernabe right. Ideally, we don't want anyone to have to customize citation.tsv and other metadata blocks we ship with Dataverse. It's common in our release notes that we ask installations to reload citation.tsv, for example.

I'm reopening it because I think there is a usability problem here. I don't have all the answers, unfortunately.

Have you looked into dataset templates? http://guides.dataverse.org/en/4.19/user/dataverse-management.html#dataset-templates . I forget if they interact with displayoncreate or not.

@pdurbin pdurbin reopened this Jan 24, 2020
@vbernabe
Copy link
Author

@pdurbin Unfortunately using the Dataset Templates doesn't show the optional fields on creation too.

I did the custom metadata route, setting the "displayoncreate" for "grant information" and it now shows up on create Dataset.

@pdurbin
Copy link
Member

pdurbin commented Jan 29, 2020

@vbernabe cool but what if afterwards you reload the citation.tsv file from a Dataverse release? Does it undo your changes?

Here's an example of a Dataverse release that indicates to reload the citation.tsv file: https://github.com/IQSS/dataverse/releases/tag/v4.18

@vbernabe
Copy link
Author

@pdurbin yes it will undo my changes if I reload a new citation.tsv file. I need to make sure that the changes I have is applied to the updated citation.tsv before I reload it. It will be better though if there is an feature on the UI to make the optional field available on initial creation of metadata.

@pdurbin
Copy link
Member

pdurbin commented Feb 24, 2020

@vbernabe ok, let me make sure I understand your current workflow:

  • Check Dataverse release notes to see if citation.tsv must be reloaded.
  • If a reload is required, edit citation.tsv from the release to make "Grant Information" (for example) available on dataset creation.
  • Reload citation.tsv

Is that right? Thanks.

@vbernabe
Copy link
Author

@pdurbin Yes this is correct.

@pdurbin
Copy link
Member

pdurbin commented Feb 26, 2020

@vbernabe ok, thanks. That does sound like a pain. I do agree we should make this easier. Expressing funding information is very important and I can understand why you want it on the shorter "create" form for datasets.

I guess a fix for you would be to simply make "Grant Information" displayoncreate=true for everybody. We did something similar for "Related Publication" recently in #3838.

Or is "Grant Information" just an example? Do you have a lot of fields that you want to be added to the "create" form?

@vbernabe
Copy link
Author

@pdurbin We have two fields "Grant Information" and "Software" that we show on the create form. It will be great if these will be displayed on create form, these fields are optional so if you make this displayoncreate=true I think it might not be an issue with others - this is just me though, I'm not sure how others will feel if this shows on the create form if they are not using it.

Ideally there should be a feature, maybe another checkbox on metadata settings?
image

However, if this will take time to be implemented we are okay either way if we will reload the citation.tsv or making "Grant Information" and "Software" part of the default create form with displayoncreate=true.

@pdurbin
Copy link
Member

pdurbin commented Feb 27, 2020

@vbernabe I mean, we are trying to encourage people to deposit code for reproducibility but I'm not sure if we really want "Software" on the create form out of the box or not. Entering funding information is also very important too, but again, we're trying to keep the "create" form somewhat short.

As we're discussing, it would be great to allow a "Display on Create" configuration option so that you don't have to do so much hacking on your citation.tsv file.

As a workaround I wonder if you or some other developer could write a wrapper script around the "reload" command. Maybe a file on the side called displayOnCreate.txt could have "Grant Information" and "Software" in it. Then the wrapper script would make the changes to the tsv file before loading it. If this sounds reasonable or interesting, you could add it as a use case to the Google doc attached to gdcc/dvcli#1 (heads up to @poikilotherm ).

@poikilotherm
Copy link
Contributor

@pdurbin @vbernabe I remembered that Phil and I discussed this displayOnCreate issue a while ago and I found it in IRC logs. I never created an issue for that, I'm sorry that one slipped through.

Your suggestion sounds reasonable @pdurbin but I think we need to think bigger, which is why I created #6700 as a first (baby) step towards salvation of #4451 (thx for linking) and #6030.

If this would help you @vbernabe please reach out there. Thanks!

@pdurbin
Copy link
Member

pdurbin commented Feb 27, 2020

@vbernabe or you are welcome to join me, @poikilotherm and the gang at https://chat.dataverse.org of course! 😄

@pdurbin pdurbin changed the title Optional Metadata not showing on Dataset Form Allow installation to decide if displayoncreate is true or false for metadata fields Oct 8, 2022
@pdurbin pdurbin added Type: Suggestion an idea Feature: Metadata User Role: Curator Curates and reviews datasets, manages permissions labels Oct 8, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 8, 2022

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
@github-project-automation github-project-automation bot moved this from 🔍 Interest to Done in Recherche Data Gouv Aug 20, 2024
@pdurbin
Copy link
Member

pdurbin commented Aug 20, 2024

This issue is more or less the same as this newer one:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metadata Type: Suggestion an idea User Role: Curator Curates and reviews datasets, manages permissions
Projects
Status: Interested
Status: Done
Development

No branches or pull requests

5 participants