-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Dataset Contact: Missing success message that email was sent #2638
Comments
Yeah, I just tried the "Email Dataset Contact" button for the first time at http://dx.doi.org/10.7910/DVN/8ZT5KF and it kind of feels like whatever I wrote went into a black hole since I didn't get any confirmation that an email was sent. I wasn't logged in and I'm not sure if that makes a difference or not. Also, I was tripped up that "From" was asking for my email address rather than my name: I also sort of wonder what would have happened if I typed my email address wrong. I assume I would just never get a reply from the author. It's on me to type my own email address correctly, of course! 😄 |
The person who just filled out the form and clicked "Send Message" should see a success message saying something like "Your message has been emailed to the dataset contact and you have been emailed a copy of the message." This fixes a couple things:
I still think that "From" should be more clear that it wants your email address, not your name. See the screenshot above. This is on my mind because as I was telling @jggautier yesterday, I'm thinking about clicking "Contact" on http://dx.doi.org/10.7910/DVN/Y3WOOE to suggest that we add the related publication to that dataset. |
This just in from @Falco-KUB at https://groups.google.com/g/dataverse-community/c/LBrYAAIfCBo/m/KQxty6KbCAAJ "I have a related (but much more simple) question/request: @Falco-KUB (or anyone reading this), if you have thoughts on what we should implement for this issue, please let us know! ❤️ |
Thanks, I suggest to always send a copy of the request by email to the person that fills out the form. Add a short text below the "From" field in the contact form (or as mouseover): There could be a checkbox to opt out from this default behaviour ("Do not send a copy of the message."). Btw. when you are logged in, the email address is automatically added to the "From" field, |
If someone who isn't logged in can add any mail address, this could potentially be used to spam people. Would it make sense to limit it to logged in users? |
How else would non-registered users be able to contact dataset owners? |
They can now, but if we add cc'ing the originating address, I can fill out the form using your address and have Dataverse send you an email asking you to come to my website. |
I hate to bring this up but if we let logged in users receive a copy of the email, spammers could sign up for an account with someone else's email address (!) and spam people that way.* That is, until we finally get around to making email validation meaningful: (Currently when you validate your email, nothing really happens except for the fact being recorded in the database. In the future, after the issue above is address, Dataverse should ONLY send email to validated email addresses.) * very unlikely! |
Considering your comment, this might actually the best option. |
For now I've made the smallest change possible (thank you @sekmiller for the assist with JSF): Please leave feedback here or there. I put a screenshot in the pull request above. |
Looks good. I would just suggest a little more detail maybe "Message sent to Dataset Contact" or something |
202/12/15: Cleaning up status following move to V2 project. Appears that this issue is still "In Progress"? @sekmiller please confirm. |
@cmbz I just removed it from the board because there's an open PR that will close this issue automatically when it is merged: |
@pdurbin sorry, just noticed this one too. Apologies /0\ |
From datasetfieldtype.datasetContactEmail.watermark
Their is no "success" notification when someone uses the "email icon" contact in a dataset. The page refreshes leaving the user wondering if an email was sent.
The text was updated successfully, but these errors were encountered: