Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Dataset Contact: Missing success message that email was sent #2638

Closed
sbarbosadataverse opened this issue Oct 13, 2015 · 17 comments · Fixed by #10188
Closed

Email Dataset Contact: Missing success message that email was sent #2638

sbarbosadataverse opened this issue Oct 13, 2015 · 17 comments · Fixed by #10188
Labels
Feature: Email Dataset Contact Size: 10 A percentage of a sprint. 7 hours. Type: Suggestion an idea
Milestone

Comments

@sbarbosadataverse
Copy link

Their is no "success" notification when someone uses the "email icon" contact in a dataset. The page refreshes leaving the user wondering if an email was sent.

@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@scolapasta scolapasta removed their assignment Jan 27, 2016
@mheppler mheppler changed the title email contact icon: user should be notified that email was successfully sent to email used in email icon Dataset Contact: Missing success message that email was sent Jan 28, 2016
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Feature: Metadata Feature: Account & User Info labels Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Oct 24, 2016

Yeah, I just tried the "Email Dataset Contact" button for the first time at http://dx.doi.org/10.7910/DVN/8ZT5KF and it kind of feels like whatever I wrote went into a black hole since I didn't get any confirmation that an email was sent. I wasn't logged in and I'm not sure if that makes a difference or not.

Also, I was tripped up that "From" was asking for my email address rather than my name:

screen shot 2016-10-24 at 9 13 51 am

I also sort of wonder what would have happened if I typed my email address wrong. I assume I would just never get a reply from the author. It's on me to type my own email address correctly, of course! 😄

@pdurbin pdurbin added the User Role: Guest Anyone using the system, even without an account label Jul 4, 2017
@pdurbin
Copy link
Member

pdurbin commented Jul 4, 2017

The person who just filled out the form and clicked "Send Message" should see a success message saying something like "Your message has been emailed to the dataset contact and you have been emailed a copy of the message." This fixes a couple things:

  • There's no more wondering if the message was sent or not because you see a success message.
  • You get a copy of the message you wrote for your records (helpful if you put a lot of thought into what you wrote) or to remind you to follow up.

I still think that "From" should be more clear that it wants your email address, not your name. See the screenshot above.

This is on my mind because as I was telling @jggautier yesterday, I'm thinking about clicking "Contact" on http://dx.doi.org/10.7910/DVN/Y3WOOE to suggest that we add the related publication to that dataset.

@pdurbin pdurbin changed the title Dataset Contact: Missing success message that email was sent Email Dataset Contact: Missing success message that email was sent Jul 4, 2017
@mheppler mheppler removed Help Wanted: Code Mentor: pdurbin UX & UI: Design This issue needs input on the design of the UI and from the product owner User Role: Guest Anyone using the system, even without an account labels Mar 4, 2021
@sbarbosadataverse sbarbosadataverse moved this to Harvard Dataverse Instance (Sonia) in IQSS Dataverse Project Oct 2, 2023
@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project Oct 11, 2023
@pdurbin
Copy link
Member

pdurbin commented Nov 16, 2023

This just in from @Falco-KUB at https://groups.google.com/g/dataverse-community/c/LBrYAAIfCBo/m/KQxty6KbCAAJ

"I have a related (but much more simple) question/request:
When using the contact form, offer to send a copy of the mail to the sender as well."

@Falco-KUB (or anyone reading this), if you have thoughts on what we should implement for this issue, please let us know! ❤️

@Falco-KUB
Copy link

Thanks, I suggest to always send a copy of the request by email to the person that fills out the form.

Add a short text below the "From" field in the contact form (or as mouseover):
"Enter your email address here. You will receive a copy of your message to this address."

There could be a checkbox to opt out from this default behaviour ("Do not send a copy of the message.").

Btw. when you are logged in, the email address is automatically added to the "From" field,

@qqmyers
Copy link
Member

qqmyers commented Nov 17, 2023

If someone who isn't logged in can add any mail address, this could potentially be used to spam people. Would it make sense to limit it to logged in users?

@Falco-KUB
Copy link

How else would non-registered users be able to contact dataset owners?

@qqmyers
Copy link
Member

qqmyers commented Nov 17, 2023

They can now, but if we add cc'ing the originating address, I can fill out the form using your address and have Dataverse send you an email asking you to come to my website.

@pdurbin
Copy link
Member

pdurbin commented Nov 17, 2023

I hate to bring this up but if we let logged in users receive a copy of the email, spammers could sign up for an account with someone else's email address (!) and spam people that way.* That is, until we finally get around to making email validation meaningful:

(Currently when you validate your email, nothing really happens except for the fact being recorded in the database. In the future, after the issue above is address, Dataverse should ONLY send email to validated email addresses.)

* very unlikely!

@Falco-KUB
Copy link

If someone who isn't logged in can add any mail address, this could potentially be used to spam people. Would it make sense to limit it to logged in users?

Considering your comment, this might actually the best option.

@scolapasta scolapasta moved this from SPRINT READY to Clear of the Backlog in IQSS Dataverse Project Dec 6, 2023
@pdurbin pdurbin self-assigned this Dec 13, 2023
@pdurbin
Copy link
Member

pdurbin commented Dec 13, 2023

For now I've made the smallest change possible (thank you @sekmiller for the assist with JSF):

Please leave feedback here or there. I put a screenshot in the pull request above.

@pdurbin pdurbin removed their assignment Dec 13, 2023
@sekmiller
Copy link
Contributor

Looks good. I would just suggest a little more detail maybe "Message sent to Dataset Contact" or something

@cmbz cmbz moved this to In Progress 💻 in IQSS Dataverse Project Dec 15, 2023
@cmbz
Copy link

cmbz commented Dec 15, 2023

202/12/15: Cleaning up status following move to V2 project. Appears that this issue is still "In Progress"? @sekmiller please confirm.

@pdurbin
Copy link
Member

pdurbin commented Dec 15, 2023

@cmbz I just removed it from the board because there's an open PR that will close this issue automatically when it is merged:

@cmbz
Copy link

cmbz commented Dec 15, 2023

@pdurbin sorry, just noticed this one too. Apologies /0\

pdurbin added a commit that referenced this issue Jan 8, 2024
From datasetfieldtype.datasetContactEmail.watermark
@pdurbin pdurbin added this to the 6.2 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Email Dataset Contact Size: 10 A percentage of a sprint. 7 hours. Type: Suggestion an idea
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants