Move publication status facet from bottom to where it used to be

[scolapasta]

In one of our recent releases, the publication status facet location was inadvertently moved to the bottom of the facet list. Let's move it back to where it used to be.

[scolapasta]

When we did some optimization for solr, a call in SearchIndexBean search method to a method called getPermissionFilterQuery got moved from before the dynamic facets were added to after. One thing this method did behind the scenes is add the publication_status facet (since this only shows if you are logged in).

To fix, we could either a) see if it can be moved back to where it was, OR since it was likely moved for good recent, be could try to leave it there, but be more judicous in adding the facet to the list (i.e. don't add it to the end, but between other facets. Of course, in this scenario, we should be careful to see where (i.e. would it always be the nth place?).

[jp-tosca]

For reference #10050 (fixes #9635) seems to be the PR that closed the mentioned issue by @scolapasta.

SearchServiceBean is the class that contains search() and getPermissionFilterQuery()

Addition of the publication_status facet.

[jp-tosca]

It seems to me that the only difference is that on the current version, there is a validation to check addFacets while on the previous one was not, it seems that everything else is being executed on the same order 🤔

dataverse/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java

Lines 1032 to 1036 in 0a5fcb8

	if (addFacets) {
	// Logged in user, has publication status facet
	//
	solrQuery.addFacetField(SearchFields.PUBLICATION_STATUS);
	}

dataverse/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java

Line 927 in 81490f8

solrQuery.addFacetField(SearchFields.PUBLICATION_STATUS);

Probably this change is older than I initially thought ❓

[qqmyers]

Check where getPermissionFilterQuery is called relative to where other facets are, e.g.

dataverse/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java

Lines 247 to 269 in 0a5fcb8

	if (dataverses != null) {
	for (Dataverse dataverse : dataverses) {
	if (dataverse != null) {
	for (DataverseFacet dataverseFacet : dataverse.getDataverseFacets()) {
	DatasetFieldType datasetField = dataverseFacet.getDatasetFieldType();
	solrQuery.addFacetField(datasetField.getSolrField().getNameFacetable());
	}
	// Get all metadata block facets configured to be displayed
	metadataBlockFacets.addAll(dataverse.getMetadataBlockFacets());
	}
	}
	}
	solrQuery.addFacetField(SearchFields.FILE_TYPE);
	/**
	* @todo: hide the extra line this shows in the GUI... at least it's
	* last...
	*/
	solrQuery.addFacetField(SearchFields.FILE_TAG);
	if (!systemConfig.isPublicInstall()) {
	solrQuery.addFacetField(SearchFields.ACCESS);
	}
	}

vs

dataverse/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java

Lines 280 to 289 in 81490f8

	solrQuery.addFacetField(SearchFields.FILE_TYPE);
	/**
	* @todo: hide the extra line this shows in the GUI... at least it's
	* last...
	*/
	solrQuery.addFacetField(SearchFields.TYPE);
	solrQuery.addFacetField(SearchFields.FILE_TAG);
	if (!systemConfig.isPublicInstall()) {
	solrQuery.addFacetField(SearchFields.ACCESS);
	}