-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harvesting feature to handle missing controlled values #10323
Add harvesting feature to handle missing controlled values #10323
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/edu/harvard/iq/dataverse/util/json/JsonParser.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/edu/harvard/iq/dataverse/harvest/client/HarvestingClient.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm leaning towards just approving this, not seeing anything to nitpick on. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Do we care that there's not a UI change for this? That is when I set up a new client via the UI we aren't allowed to set the new param, nor do we see its value in the in the list of completed clients. Works fine when setting up client via api or if you modify the param directly in the db. |
Maybe we should say something about the new setting here: https://guides.dataverse.org/en/6.1/admin/harvestclients.html |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
cherry-picking: Add harvesting feature to handle missing controlled values IQSS#10323
What this PR does / why we need it: Allows datasets to be harvested with Controlled Vocabulary Values that existed in the originating Dataverse Project but are not in the harvesting Dataverse Project.
Which issue(s) this PR closes: #9992
Closes #9992
Special notes for your reviewer:
Suggestions on how to test this: See HarvestingClientsIT.java for examples.
Does this PR introduce a user interface change? No
Is there a release notes update needed for this change?: in 9992-harvest-metadata-values-not-in-cvv-list.md
Additional documentation: