Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watermarks of the (QDR) 'External Vocabulary' scripts that have been applied on the Author and Funding fields on demo.dataverse.org #327

Closed
cmbz opened this issue Dec 10, 2024 · 8 comments
Labels
GREI 2 Issue is related to GREI Consistent Metadata objective Metadata Block Size: 3 A percentage of a sprint.

Comments

@cmbz
Copy link
Collaborator

cmbz commented Dec 10, 2024

Overview

Related

@cmbz cmbz added Metadata Block GREI 2 Issue is related to GREI Consistent Metadata objective labels Dec 10, 2024
@cmbz cmbz added the Size: 3 A percentage of a sprint. label Dec 10, 2024
@cmbz
Copy link
Collaborator Author

cmbz commented Dec 10, 2024

2024/12/10: Preliminary sizing of 3, please resize as needed to reflect actual work.

@cmbz cmbz moved this to SPRINT READY in IQSS Dataverse Project Dec 10, 2024
@cmbz cmbz changed the title Update (QDR) citation block watermark on demo Update (QDR) citation block watermark on demo.dataverse.org Dec 10, 2024
@jggautier jggautier changed the title Update (QDR) citation block watermark on demo.dataverse.org Update watermarks of the (QDR) 'External Vocabulary' scripts that have been applied on the Author and Funder fields on demo.dataverse.org Dec 10, 2024
@jggautier jggautier changed the title Update watermarks of the (QDR) 'External Vocabulary' scripts that have been applied on the Author and Funder fields on demo.dataverse.org Update watermarks of the (QDR) 'External Vocabulary' scripts that have been applied on the Author and Funding fields on demo.dataverse.org Dec 13, 2024
@qqmyers qqmyers moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Dec 17, 2024
@qqmyers qqmyers self-assigned this Dec 17, 2024
@qqmyers
Copy link
Member

qqmyers commented Dec 17, 2024

Demo is updated with the latest ORCID/ROR scripts, including new 'Select or enter...; placeholders, and styling from #11106.

FWIW: The ability customize the placeholder dynamically is supported by the scripts, but evidently not in Dataverse itself. The data-cvoc-placeholder param isn't in the external vocab schema and the Dataverse code always sends the value "" for it. For now, I expect 'Select or enter...' is fine for everyone but if we want the ability for sites to customize, it is still to be built.

@qqmyers qqmyers moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Dec 17, 2024
@cmbz
Copy link
Collaborator Author

cmbz commented Dec 17, 2024

@jggautier is this a functionality you think that users will want? If so, can you create an issue with the right GREI labels, add to the GREI 2 tracking issue, and then make sure we discuss at the next prioritization meeting? Thanks!

@jggautier
Copy link
Collaborator

Hi @cmbz and @qqmyers. I'd like to understand this better.

When installation admins change their repository's fields to use the controlled vocabulary functionality, wouldn't they be able to customize the placeholder in the same way that you changed it for Demo Dataverse @qqmyers?

@qqmyers
Copy link
Member

qqmyers commented Dec 18, 2024

I changed it here- https://github.com/gdcc/dataverse-external-vocab-support/blob/dce1a0d3788ab316b03e893b8085faafb1854937/scripts/people.js#L133 because the data-cvoc-placeholder setting is not yet being sent. So yes - anyone could edit the script, but they'd be forking the script rather than changing a config setting for their local Dataverse.

@jggautier
Copy link
Collaborator

jggautier commented Dec 18, 2024

Ah that helps. Thanks @qqmyers.

I'm not sure if other installation admins will want to more easily change the placeholders. But admins from QDR and DANS have already changed some of their metadata fields by using external controlled vocabulary functionality. And a couple of other installations have checked out the changes on Demo Dataverse before the placeholder was changed and it seemed like they were interested in using the external controlled vocabulary functionality to change one or more fields in their Dataverse installations.

I could follow up to ask them, but @qqmyers, would you happen to know what placeholders QDR and DANS are using now? If they don't plan to use "Select or enter...", I imagine they'll want to make sure they can use other placeholder text without having to fork the script, too.

@qqmyers
Copy link
Member

qqmyers commented Dec 18, 2024

My guess is that no one will care about the current change but being able to change and/or internationalize it in the future is useful, although not really a priority at the moment.

@jggautier
Copy link
Collaborator

Ah okay. I'll take that to mean that QDR and DANS are not using "Select or enter...", but you think other installations would want to, or at least want to be able to change the language of the placeholders, which means that the ability to customize the placeholder dynamically would need to be supported in Dataverse itself.

I think I understand enough to create a GitHub issue and add the GREI 2 tracking issue. I'll leave a note to remind myself to bring it up at the next prioritization meeting.

Since the watermarks/placeholder text has been changed for the fields on Demo Dataverse, I'll close this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI 2 Issue is related to GREI Consistent Metadata objective Metadata Block Size: 3 A percentage of a sprint.
Projects
Status: Done 🧹
Development

No branches or pull requests

3 participants