-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection Page Facets Filters #566
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! Just a minor comment about the query parameters.
tests/e2e-integration/e2e/sections/collection/CollectionItemsPanel.spec.ts
Outdated
Show resolved
Hide resolved
@ekraffmiller thanks, ready for review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved!
@ofahimIQSS Wait to test until #563 is merged and I update this branch with develop |
563 has been merged |
@ofahimIQSS ready! |
Ran across an issue while testing this PR, see video clip below: Screen.Recording.2024-12-20.at.2.06.28.PM.mov |
Hi @ofahimIQSS I think this is not related to the SPA at all, what I do see is that when you are redirected to the login page the port is absent in the URL, maybe that gives us a clue, I will check it in my environment. |
What this PR does / why we need it:
Adds the facet filtes in the Collection Page.
See original issue
Which issue(s) this PR closes:
Special notes for your reviewer:
Wait to test until #563 is merged and I update this branch with develop.
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
http://localhost:8000/spa/collections
and in another tab tohttp://localhost:8000
and apply same filters in the SPA version and JSF version (search; filter by collection, datasets or files; select and remove facets). Check that they show the same items and facets list.*Note that for now, for the selected facets button labels, we are only showing the facet value, so when in the JSF version you will see "Author Name: John" in the SPA you will just see "John".
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Is there a release notes update needed for this change?:
No
Additional documentation:
No