diff --git a/src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts b/src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts index fb921b418..5461f9b8b 100644 --- a/src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts +++ b/src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts @@ -72,10 +72,14 @@ export function useFileSelection( useEffect(() => { setFileSelection(updateFileSelection()) + // TODO: Not a priority as the one for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [currentPageSelectedRowModel]) useEffect(() => { setCurrentPageRowSelection(computeCurrentPageRowSelection()) + // TODO: Not a priority as the one for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [paginationInfo]) return { diff --git a/src/sections/dataset/dataset-files/useFiles.tsx b/src/sections/dataset/dataset-files/useFiles.tsx index afd1fa222..4244c6fdf 100644 --- a/src/sections/dataset/dataset-files/useFiles.tsx +++ b/src/sections/dataset/dataset-files/useFiles.tsx @@ -72,6 +72,9 @@ export function useFiles( console.error('There was an error getting the files') setIsLoading(false) }) + + // TODO: Not a priority as the one for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [ filesRepository, datasetPersistentId, diff --git a/src/sections/shared/pagination/PaginationControls.tsx b/src/sections/shared/pagination/PaginationControls.tsx index dcbd57da3..82f56ee8e 100644 --- a/src/sections/shared/pagination/PaginationControls.tsx +++ b/src/sections/shared/pagination/PaginationControls.tsx @@ -42,6 +42,8 @@ export function PaginationControls({ useEffect(() => { onPaginationInfoChange(paginationInfo) + // TODO: Not a priority as not used for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [paginationInfo.pageSize]) useEffect(() => { @@ -52,10 +54,14 @@ export function PaginationControls({ setSearchParams(searchParams) } } + // TODO: Not a priority as not used for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [paginationInfo.page]) useEffect(() => { setPaginationInfo(paginationInfo.withTotal(initialPaginationInfo.totalItems)) + // TODO: Not a priority as not used for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [initialPaginationInfo.totalItems]) useEffect(() => { @@ -67,6 +73,8 @@ export function PaginationControls({ goToPage(page) } } + // TODO: Not a priority as not used for inifinite scroll is used but the eslint disable should be removed and the dependency should be added + // eslint-disable-next-line react-hooks/exhaustive-deps }, [searchParams]) if (paginationInfo.totalPages < MINIMUM_NUMBER_OF_PAGES_TO_DISPLAY_PAGINATION) {