Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for expected data rectangles and file contents #70

Closed
2 of 3 tasks
wibeasley opened this issue Dec 31, 2020 · 2 comments
Closed
2 of 3 tasks

Test for expected data rectangles and file contents #70

wibeasley opened this issue Dec 31, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@wibeasley
Copy link
Contributor

wibeasley commented Dec 31, 2020

As part of the test suite (#4), the retrieved data & files should be compared to their expected values/file/data. Some of the options are:

@wibeasley wibeasley self-assigned this Dec 31, 2020
@wibeasley wibeasley changed the title expected data rectangles expected data rectangles & file contents Dec 31, 2020
wibeasley added a commit that referenced this issue Dec 31, 2020
wibeasley added a commit that referenced this issue Dec 31, 2020
@kuriwaki
Copy link
Member

kuriwaki commented Jan 2, 2021

What's the difference between the second and third items? Once a tabular datafile is read into R, it's already a dataframe.

If we want to go for extensive tests, I think we want tests for:

  • ingested datafiles read in in their ingested (tab plain text) form
  • ingested datafiles read in their original form (which may be csv, dta, sav, xlsx - see supported formats).
  • non -ingested datafiles (e.g. a rds file nlsw_rds-export.rds) read in their original form

@kuriwaki kuriwaki changed the title expected data rectangles & file contents Test for expected data rectangles and file contents Dec 21, 2021
kuriwaki added a commit that referenced this issue Dec 24, 2021
@kuriwaki kuriwaki added this to the CRAN 0.3.10 milestone Dec 24, 2021
@kuriwaki
Copy link
Member

The above commits give decent tests for rds and rda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants