-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language controller #8
Comments
@kjaebker The language controller is one step further than a localisation (issue 6). A language controller makes multilingual tours possible, whereas the localisation makes localised tours possible (tours and app in the local language). |
Yes. Going forward, like you mentioned, we'll provide a language icon that will be displayed on the tour selection screen. Pressing it will provide the user with a modal and a listing of languages. Selecting one should reload the current view and once they dive in, it should be handled automatically. |
Great. For consistency, we could provide a table view with the languages instead of a modal. Additionally we can also change the UI language. We need to replace the function NSLocalizableString with a custom function because the function doesnt change on-the-fly", ie |
Any progress or news on code of a language selector? Should I submit a patch? |
This should be close. We discovered a issue that might arise utilizing localized bundles with core data and believe to have a solution to push forward. Daniel Cervantes On Feb 11, 2013, at 3:59 AM, "Hanno Lans" <[email protected]mailto:[email protected]> wrote: Any progress or news on code of a language selector? Should I submit a patch? — This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact Daniel Cervantes by reply email and destroy all copies of the original message. |
Good to hear. What is your proposed solution? Adding an alternative function instead of NSLocalizableString to make live switching of the user interface possible? What do you mean with the issue utilizing localised bundles with core data? Is it possible to share the code to have a look on it? |
The issue stems with the fact that TAP CMS exports localized bundles. When the app initializes, it loads the TourML from users current language. If we were to change languages on the fly, the TourML wouldn't update because the tour id and timestamp would remain the same. To resolve this we're going to prefix the tour id with the current language. Unfortunately I have the code in a stash at the moment while I work to add several other big updates. In essence though, on the Tour Selection view, we are placing a language icon on the top right. When clicked a language selection view will be modally displayed. When the user selects the language that should kick off the loading of the appropriate string localizations as well as reload the specified language in TourML. |
Ah. This doesn't happen when we have the language ids on a stop base and one tour. |
Correct. We've been going back and forth on which route to go since Apple recommends creating a localized bundle. Speaking with others, we might just go the route of using a single TourML doc. This will require us to update Tap CMS to use the this method of Bundle exporting. |
Cool. Yeah I think creating one tour with languageids in the tourml doc is the best approach. |
Would be great if we have a language controller, so a user can pick tours in a selected language.
For this we need:
The text was updated successfully, but these errors were encountered: