Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme override #4

Open
hannolans opened this issue Sep 26, 2012 · 6 comments
Open

Theme override #4

hannolans opened this issue Sep 26, 2012 · 6 comments
Assignees

Comments

@hannolans
Copy link
Contributor

When you do a checkout of the code your theme images can get overridden with the default images of IMA. Is it possible to have a directory where you can keep your own theme or reorganise it in a separate directory that we can git ignore?

@karnold
Copy link

karnold commented Sep 26, 2012

Hi Hanno,
The best way to handle this is to create a sub theme for drupal. Sub themes will inherit from the base theme and allow you to override certain functionality. More info is available here http://drupal.org/node/225125

From: Hanno Lans <[email protected]mailto:[email protected]>
Reply-To: IMAmuseum/tap-ios <[email protected]mailto:[email protected]>
Date: Wed, 26 Sep 2012 13:23:45 -0700
To: IMAmuseum/tap-ios <[email protected]mailto:[email protected]>
Subject: [tap-ios] Theme override (#4)

When you do a checkout of the code your theme images can get overridden with the default images of IMA. Is it possible to have a directory where you can keep your own theme or reorganise it in a separate directory that we can git ignore?


Reply to this email directly or view it on GitHubhttps://github.com//issues/4.


This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact Kris Arnold by reply email and destroy all copies of the original message.

@cmoad
Copy link
Contributor

cmoad commented Sep 26, 2012

Looks like this suggestion is specific to the iOS app. In that case, it is a harder question. Forking the repository might be the best approach if you plan on making a round of changes. You can always pull changes across after the fact.

@cmoad cmoad closed this as completed Sep 26, 2012
@hannolans
Copy link
Contributor Author

Yes, this is specific for the iOS app. I would prefer not to fork as we can then contribute and get new changes form the app.
Possibly as long as it are only the image files, and the names and dimensions stay the same, it could just work to ignore these image files in git. Is it possible to put these files in a special directory, so you can add this to you .gitignore file?

@cmoad
Copy link
Contributor

cmoad commented Sep 27, 2012

I don't think ignoring the media is an option because we want the app to run out of the box. I also don't know of a way that iOS allows you to override graphics. Assigning to Dan to see if he has any ideas. Otherwise I still think forking is easiest. This lets you easily pull changes back and forth including making it easier for you to provide pull requests with enhancements.

@cmoad cmoad reopened this Sep 27, 2012
@ghost ghost assigned dlferro Sep 27, 2012
@hannolans
Copy link
Contributor Author

Yes, forking is an option for now. Roadmap for the future could be that museums can upload the theme images in the TAP-CMS and can export this to the app?

@dlferro
Copy link
Contributor

dlferro commented Sep 27, 2012

At the moment the only items that we do not currently export on the authoring side are the keypad graphics, the top banner, and the initial animation graphics. Now the initial splash screen and application icon can not be themed this way because they are handled differently by the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants