-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages for every member #24
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da1c287
Members collection in Jekyll & basic layout for it
peey e905015
Move member-page css to separate file
peey 85b2a5d
Fix footer at bottom
peey 8cfe736
Samples of what members could embed in their pages
peey ceb137d
Naming Consistency: usage of "member page"
peey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,9 @@ | |
# you will see them accessed via {{ site.title }}, {{ site.email }}, and so on. | ||
# You can create any custom variable you would like, and they will be accessible | ||
# in the templates via {{ site.myvariable }}. | ||
|
||
# Metadata | ||
|
||
title: Byld | ||
email: [email protected] | ||
author: Peeyush Kushwaha, Viresh Gupta | ||
|
@@ -22,12 +25,25 @@ description: >- # this means to ignore newlines until "baseurl:" | |
Google search results) and in your feed.xml site description. | ||
keywords: Byld, IIIT-Delhi, Software Development, Club, Programming | ||
lang: en-IN | ||
favicon: "/assets/images/favicon.png" | ||
fb_username: byld.iiitd | ||
github_username: IIIT-Delhi | ||
|
||
# Config | ||
|
||
baseurl: "/byldWebsite" # the subpath of your site, e.g. /blog | ||
url: "https://virresh.github.io" # the base hostname & protocol for your site, e.g. http://example.com | ||
fb_username: byld.iiitd | ||
github_username: IIIT-Delhi | ||
favicon: "/assets/images/favicon.png" | ||
collections: | ||
members: | ||
output: true | ||
permalink: /:collection/:name | ||
defaults: | ||
- | ||
scope: | ||
path: "" | ||
type: "members" | ||
values: | ||
layout: "member-page" | ||
|
||
# Build settings | ||
markdown: kramdown | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<!-- Subpage Layout Start --> | ||
|
||
<!DOCTYPE html> | ||
<html lang="{{ site.lang }}"> | ||
|
||
{% include head.html %} | ||
|
||
<body id="page-top"> | ||
<div id="page-container"> | ||
|
||
{% include navigation.html %} | ||
|
||
<div class="container-fluid"> | ||
<div class="row-fluid" id="per-member-page-container"> | ||
<div class="col-md-12"> | ||
<div class="above-the-line"> | ||
<span class="member-name">{{page.name}}</span> | ||
</div> | ||
<!-- We're in control of the display above the line - allows us to maintain consistency. But allow arbitary HTML below the line --> | ||
<!-- Allowing it would give people freedom to make their page their own, because otherwise they may not be interested in making their page at all. --> | ||
<!-- Stuff which custom HTML would allow - Github links, fontawesome icons, embed tweets, embed buttons to github, show off your stackexchange points, etc--> | ||
<hr class="member-content-separation-line"> | ||
<div class="member-content"> | ||
{{ content }} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
<div id="page-bottom"> | ||
{% include footer.html %} | ||
</div> | ||
</div> <!-- page container ends --> | ||
|
||
{% include js.html %} | ||
</body> | ||
</html> | ||
|
||
<!-- Subpage Layout End --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
name: Bob, The | ||
--- | ||
|
||
<p> Bob is an avid bylder </p> | ||
|
||
Here's bob's twitter feed: | ||
|
||
<div style="height:300px; width: 500px; overflow: scroll;"> | ||
<a class="twitter-timeline" href="https://twitter.com/BobtheBuilder?ref_src=twsrc%5Etfw">Tweets by BobtheBuilder</a> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script> | ||
</div> | ||
|
||
Bob doesn't have a GitHub account, but Bob wants you to follow IIITD's account on GitHub | ||
<!-- Place this tag where you want the button to render. --> | ||
<a class="github-button" href="https://github.com/IIIT-Delhi" data-size="large" aria-label="Follow @IIIT-Delhi on GitHub">Follow @IIIT-Delhi</a> | ||
<!-- Place this tag in your head or just before your close body tag. --> | ||
<script async defer src="https://buttons.github.io/buttons.js"></script> | ||
|
||
In his free time, Bob answers questions on the StackExchange network | ||
|
||
<a href="https://stackexchange.com/users/11683/jon-skeet"><img src="https://stackexchange.com/users/flair/11683.png" width="208" height="58" alt="profile for Jon Skeet on Stack Exchange, a network of free, community-driven Q&A sites" title="profile for Peeyush Kushwaha on Stack Exchange, a network of free, community-driven Q&A sites" /></a> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#per-member-page-container { | ||
padding: 150px 10px 30px; /* top side bottom */ | ||
} | ||
|
||
.member-content-separation-line { | ||
border-top: 1px solid #cecece; | ||
} | ||
|
||
/** | ||
* Note: the below 3 rules are to make the footer stay at the bottom even if user's page's content is too short | ||
* See https://stackoverflow.com/a/27812717 | ||
* Problem with absolute positioning layout is that if screen height is too small (mobile devices), then the footer overlaps the content | ||
* Problem with css table based layout is I'm unable to get the heights to work | ||
* In browsers which don't support flexbox or viewport units ( <= IE10 & opera mini), the footer will simply appear not at the bottom of the page if the content is too short, nothing else should be affected | ||
*/ | ||
#page-bottom { | ||
margin-top: auto; | ||
} | ||
|
||
#page-container { | ||
display: flex; | ||
flex-direction: column; | ||
min-height: 100vh; | ||
} | ||
|
||
body { | ||
min-height: 100vh; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you can combine this and the above clause using an or conditional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They load different CSS files.
Besides, I'm thinking about removing this. I don't think this should be in includes, instead how about this - head include just has the common tags and css tags common to all pages. It doesn't have
<head>
so you wrap the include in a<head>
tag and then you can also add stuff to head from the page which is including (layout-specific css files and titles, for instance)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant here was to combine the css files since I didn't see any conflicting rules
But probably it's better this way only
Also about the tag:
We probably can allow that, but the other alternative could be allowing them to specify a page variable that is used to load css files in here
And let the rest of the stuff be as it is (thus it eliminates these if conditionals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it's unnecessary coupling between the modules.
That way, modules need to be aware about this API which the header include provides, and then header needs to be updated whenever anything which depends on it is updated to add a new rule.
I think this is an anti-pattern, when we can have it without coupling - you just include common things and all custom things go in their own layout files. Logic stays more local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's go for it then 👍
The only reason I wanted header to be an include was my personal mistrust towards users that they will not include the common files (it's too much work for most to read a documentation properly),
And usually they end up with certain bugs
header as an include enforces things a little more strictly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Though anyone working on source would def have to include all the common contents of the head because of bootstrap and favicon, hopefully that provides some defense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge after doing this