Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edit buttons #51

Open
peey opened this issue Jul 17, 2018 · 2 comments
Open

Add edit buttons #51

peey opened this issue Jul 17, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@peey
Copy link
Collaborator

peey commented Jul 17, 2018

Small unobtrusive buttons on each page which take you to the .md file of that page.

Like you find on readthedocs:

image

Currently if you don't know about the repo, you don't know that this website is editable
@virresh
Copy link
Member

virresh commented Jul 17, 2018

An alternative could be Fork me ribbons:
https://blog.github.com/2008-12-19-github-ribbons/

@peey
Copy link
Collaborator Author

peey commented Jul 17, 2018

Should we have per-page "edit this file" functionality tho?

Pros: faster "mistake to edit" response, also bypases having to find the file responsible for the page

Cons: people might skip contributing guide and then we'll ask them to fix things in PR comments

@sedflix sedflix added the enhancement New feature or request label Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peey @virresh @sedflix