From eb90c6daebfe16ff216f69347a88a060f6bf1302 Mon Sep 17 00:00:00 2001 From: julee Date: Wed, 17 Jul 2024 12:37:47 +0800 Subject: [PATCH 1/2] fix: initialize splitViewWidgetState to prevent uninitialized use in ViewStateHandler::savePlaylist Ensure that the splitViewWidgetState member is properly initialized to avoid using the uninitialized member `splitting` in the ViewStateHandler::savePlaylist method. --- YUViewLib/src/ui/ViewStateHandler.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/YUViewLib/src/ui/ViewStateHandler.h b/YUViewLib/src/ui/ViewStateHandler.h index 3055b5507..48beeabc9 100644 --- a/YUViewLib/src/ui/ViewStateHandler.h +++ b/YUViewLib/src/ui/ViewStateHandler.h @@ -105,11 +105,11 @@ public slots: class splitViewWidgetState { public: - QPointF centerOffset; - double zoomFactor; - bool splitting; - double splittingPoint; - int viewMode; + QPointF centerOffset{}; + double zoomFactor{}; + bool splitting{}; + double splittingPoint{}; + int viewMode{}; }; splitViewWidgetState viewStates[8]; From 431f236b7fa8728635bd9a5473e7b0207ec13f41 Mon Sep 17 00:00:00 2001 From: ChristianFeldmann Date: Mon, 29 Jul 2024 14:53:11 +0200 Subject: [PATCH 2/2] Test new runners with updated Qt --- .github/workflows/Build.yml | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/Build.yml b/.github/workflows/Build.yml index e2acbfaec..9918cf558 100644 --- a/.github/workflows/Build.yml +++ b/.github/workflows/Build.yml @@ -38,7 +38,8 @@ jobs: strategy: matrix: include: - - os: macos-12 + - os: macos-13 + - os: macos-14 steps: - uses: actions/checkout@v4 - run: git fetch --prune --unshallow @@ -59,22 +60,22 @@ jobs: matrix: include: - os: ubuntu-20.04 - QT_FILE: qtBase_6.5.2_ubuntu20.zip + QT_FILE: qtBase_6.7.2_ubuntu20.zip LIBDE265_REMOTE: libde265.so LIBDE265_LOCAL: libde265-internals.so ARTIFACT_NAME: YUView.Ubuntu20.AppImage CPU_COUNT_COMMAND: nproc - - os: macos-11 - QT_FILE: qtBase_6.5.2_mac11.zip + - os: macos-12 + QT_FILE: qtBase_6.7.2_mac12.zip LIBDE265_REMOTE: libde265.dylib LIBDE265_LOCAL: libde265-internals.dylib - ARTIFACT_NAME: YUView-Mac11-BigSur.zip + ARTIFACT_NAME: YUView-Mac12-Monterey.zip CPU_COUNT_COMMAND: sysctl -n hw.logicalcpu - - os: macos-12 - QT_FILE: qtBase_6.5.2_mac12.zip + - os: macos-14 + QT_FILE: qtBase_6.7.2_mac14.zip LIBDE265_REMOTE: libde265.dylib LIBDE265_LOCAL: libde265-internals.dylib - ARTIFACT_NAME: YUView-Mac12-Monterey.zip + ARTIFACT_NAME: YUView-Mac12-Sonoma.zip CPU_COUNT_COMMAND: sysctl -n hw.logicalcpu steps: - uses: actions/checkout@v4 @@ -84,7 +85,7 @@ jobs: cd ../../ mkdir -p YUViewQt/YUViewQt cd YUViewQt/YUViewQt - curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/QtBase-6.5.2/${{matrix.QT_FILE}} -o Qt.zip + curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/QtBase-6.7.2/${{matrix.QT_FILE}} -o Qt.zip unzip -qa Qt.zip echo "$GITHUB_WORKSPACE/../../YUViewQt/YUViewQt/Qt/bin" >> $GITHUB_PATH shell: bash @@ -149,11 +150,11 @@ jobs: - os: windows-2019 auto_update: true ARTIFACT_NAME: YUView-Win2019.zip - QT_FILE: qtBase_6.5.2_win2019.zip + QT_FILE: qtBase_6.7.2_win2019.zip - os: windows-2019 auto_update: false ARTIFACT_NAME: YUView-Win2019-noautoupdate.zip - QT_FILE: qtBase_6.5.2_win2019.zip + QT_FILE: qtBase_6.7.2_win2019.zip steps: - uses: actions/checkout@v4 - uses: ilammy/msvc-dev-cmd@v1 @@ -163,7 +164,7 @@ jobs: cd ../../ mkdir -p YUViewQt/YUViewQt cd YUViewQt/YUViewQt - curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/QtBase-6.5.2/${{matrix.QT_FILE}} -o Qt.zip + curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/QtBase-6.7.2/${{matrix.QT_FILE}} -o Qt.zip 7z x Qt.zip echo "${{ github.workspace }}\..\..\YUViewQt\YUViewQt\Qt\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append - name: Install libde265 @@ -177,7 +178,7 @@ jobs: run: | mkdir openSSL cd openSSL - curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/openSSL1.1.1u/openSSL_1_1_1u_win2019.zip -o openSSL.zip + curl -L https://github.com/ChristianFeldmann/YUViewQt/releases/download/openSSL1.1.1w/openSSL_1_1_1w_win2019.zip -o openSSL.zip 7z x openSSL.zip cd .. - name: Activate auto update