feat: apply item row operations, e.g. filter, on task progress bar data rows #2543
+68
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Makes the following changes to the
task_card
andtask_progress_bar
components:shuffle
,sort
,filter
,reverse
andlimit
. These operations will be applied to the data list rows of subtasks that make up the progress through the named task group.filter: @item.id !== @local.excluded_task_id;
filter
, as requested by [FEATURE] Ability to filter task groups #2537shuffle
,sort
andreverse
operations will have no effect. However it makes sense to expose the same logic. It may make sense to just explicitly exposefilter
andlimit
as options, but currently all operations are technically applied.completed_column_name
to the task-card componenttask_progress_bar
, but was not exposed to thetask_card
component.The
filter
parameter should function the same as it does when set on adata-items
component row. This means it has the same limitations:_index
,_id
,_first
,_last
metadata properties, since these are only applied in a data-items context@item.id
@item.row_index
The task-card and task-progress-bar components contain logic for handling task completion status via two methods:
Further changes could be made to the code of these components to clarify this and potentially further separate the logic for each system, but that could be done in a follow-up PR.
Testing
Examine the linked templates below and test in-app to ensure they behave as expected.
Git Issues
Closes #2537, #2507
Screenshots/Videos
comp_task_card
comp_task_progress_bar