Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Define Climatic Dialogue Autofill with Min and Max Names #9275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Nov 25, 2024

Fixes #9272
@rdstern have a look? This fixes items a) b)

@rdstern
Copy link
Collaborator

rdstern commented Nov 25, 2024

@N-thony you have missed the main point in item a) in #9272 . I have now put a bit there in bold! Now you have fixed to recognise max and min, you can leave that. But the point is that occasionally the dialog will NOT recognise certain elements, and you then have to fill yourself what they are. That's fine.

What is going wrong is that when you return to that fialog in another session, having opened that same file, then it should remember the entries you typed manually, because they are still the climatic elements - and recognised in the metadata. But it doesn't.

You could try, with dodoma is you rename tmin to say nnn and tmax as xxx. Then use the dialog. Then save the file and close R-Instat. Then return and open these data again.

In the data from Bangladesh it now recognises max and min, but not wind - which is the wind speed. I am happy to fill in manually, but it then needs to fill in for me, when I return to the dialog in a later session.

I hope that's clear now?

@N-thony
Copy link
Collaborator Author

N-thony commented Nov 26, 2024

@N-thony you have missed the main point in item a) in #9272 . I have now put a bit there in bold! Now you have fixed to recognise max and min, you can leave that. But the point is that occasionally the dialog will NOT recognise certain elements, and you then have to fill yourself what they are. That's fine.

What is going wrong is that when you return to that fialog in another session, having opened that same file, then it should remember the entries you typed manually, because they are still the climatic elements - and recognised in the metadata. But it doesn't.

You could try, with dodoma is you rename tmin to say nnn and tmax as xxx. Then use the dialog. Then save the file and close R-Instat. Then return and open these data again.

In the data from Bangladesh it now recognises max and min, but not wind - which is the wind speed. I am happy to fill in manually, but it then needs to fill in for me, when I return to the dialog in a later session.

I hope that's clear now?

@rdstern, I get it now and this becomes more interesting in how we would dynamically add new element in the list. Let me see if that is possible with the current implementation where we predefined elements, otherwise we will have to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor improvements needed on the Define Climatic Dialog
2 participants