Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_deepcopy_objective fails #1520

Open
dweindl opened this issue Nov 26, 2024 · 0 comments
Open

test_deepcopy_objective fails #1520

dweindl opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels

Comments

@dweindl
Copy link
Member

dweindl commented Nov 26, 2024

https://github.com/ICB-DCM/pyPESTO/actions/runs/12026858059/job/33526668472:

___________________________ test_deepcopy_objective ____________________________

    def test_deepcopy_objective():
        """Test copying objectives (needed for MultiProcessEngine)."""
        petab_importer = pypesto.petab.PetabImporter.from_yaml(
            os.path.join(
                models.MODELS_DIR,
                "Boehm_JProteomeRes2014",
                "Boehm_JProteomeRes2014.yaml",
            )
        )
        factory = petab_importer.create_objective_creator()
        objective = factory.create_objective()
    
        objective.amici_solver.setSensitivityMethod(
            amici.SensitivityMethod_adjoint
        )
    
        objective2 = copy.deepcopy(objective)
    
        # test some properties
        assert (
            objective.amici_model.getParameterIds()
            == objective2.amici_model.getParameterIds()
        )
        assert (
            objective.amici_solver.getSensitivityOrder()
            == objective2.amici_solver.getSensitivityOrder()
        )
        assert (
            objective.amici_solver.getSensitivityMethod()
            == objective2.amici_solver.getSensitivityMethod()
        )
        assert len(objective.edatas) == len(objective2.edatas)
    
        assert objective.amici_model is not objective2.amici_model
        assert objective.amici_solver is not objective2.amici_solver
>       assert objective.steadystate_guesses is not objective2.steadystate_guesses
E       AttributeError: 'AmiciObjective' object has no attribute 'steadystate_guesses'. Did you mean: 'reset_steadystate_guesses'?

test/base/test_engine.py:114: AttributeError
@dweindl dweindl added the CI label Nov 26, 2024
@dweindl dweindl self-assigned this Nov 26, 2024
dweindl added a commit that referenced this issue Nov 26, 2024
* Fix test_deepcopy_objective (Fixes #1520)
* Fix test_preeq_guesses 

Failures were related to changes in amici's default steady-state settings.
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 27, 2024
* Don't cache the amici installation.
  We are using amici/develop on purpose to detect problems early on. E.g., ICB-DCM#1520 should have been detected much earlier.
* Ignore `amici_models` when collecting tests
* Use external BNGPATH if set
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 27, 2024
* Don't cache the amici installation.
  We are using amici/develop on purpose to detect problems early on. E.g., ICB-DCM#1520 should have been detected much earlier.
* Ignore `amici_models` when collecting tests
* Use external BNGPATH if set
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
…1523)

* Don't cache the amici installation.
  We are using amici/develop on purpose to detect problems early on. E.g., #1520 should have been detected much earlier.
* Ignore `amici_models` when collecting tests
* Use external BNGPATH if set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant