You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Continuing on #1461 / #1473
It looks like there is unnecessary computation in the evidence tests. There are optimize.minimize and sample.sample calls there. These could be done once locally and the samples stored, to speed up the tests and remove most sources of non-deterministic behavior in the tests. The stored samples could also be reused in test_samples_ci, test_ground_truth, test_autocorrelation_pipeline too, since sample generation is already tested in test_pipeline.
The remaining non-deterministic thing would be in the bridge sampling itself, e.g.
Continuing on #1461 / #1473
It looks like there is unnecessary computation in the evidence tests. There are
optimize.minimize
andsample.sample
calls there. These could be done once locally and the samples stored, to speed up the tests and remove most sources of non-deterministic behavior in the tests. The stored samples could also be reused intest_samples_ci
,test_ground_truth
,test_autocorrelation_pipeline
too, since sample generation is already tested intest_pipeline
.The remaining non-deterministic thing would be in the bridge sampling itself, e.g.
pyPESTO/pypesto/sample/evidence.py
Lines 348 to 352 in 61c912d
This could be resolved with a random seed, ideally like
so that users can specify a random seed via numpy's newer/recommended rng.
There are some other things that aren't clear to me:
test_harmonic_mean_log_evidence
, but not intest_bridge_sampling
?The text was updated successfully, but these errors were encountered: