Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Bug in Visualization in case of only inadmissable values #1471

Open
PaulJonasJost opened this issue Sep 19, 2024 · 1 comment
Open
Labels
question Further information is requested

Comments

@PaulJonasJost
Copy link
Collaborator

In this test visualization failed. To my estimate it is highly likely that this happened due to only inf/nan values in one of the results. What is expected behaviour here? I do see a line to have it actually fail, but we could also return an empty axis?

@PaulJonasJost PaulJonasJost added the question Further information is requested label Sep 19, 2024
@PaulJonasJost PaulJonasJost changed the title Potential Bug in Visualization Potential Bug in Visualization in case of only inadmissable values Sep 19, 2024
@dweindl
Copy link
Member

dweindl commented Sep 23, 2024

IndexError: arrays used as indices must be of integer (or boolean) type

This is definitely a bug. Probably fixed by an explicit dtype in np.asarray(start_indices) in process_start_indices.

I agree that an empty plot is probably what most users would expect.

There is already this warning:

Some start indices were removed due to inf or nan function values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants
@dweindl @PaulJonasJost and others