Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build archive contains toolkit documentation. #14

Open
ddebrunner opened this issue Oct 29, 2018 · 1 comment
Open

Build archive contains toolkit documentation. #14

ddebrunner opened this issue Oct 29, 2018 · 1 comment

Comments

@ddebrunner
Copy link
Member

ddebrunner commented Oct 29, 2018

There's extra stuff being put in the build archive that is not needed at compile time and bloats the build archive.

When topology creates a build archive it excludes these items from a toolkit (relative to the root):

  • toolkit.xml
  • doc
  • output
  • samples
  • opt/client

https://github.com/IBMStreams/streamsx.topology/blob/c522e24e4ad954ad7acb88b29d023b86a07dc04a/java/src/com/ibm/streamsx/topology/internal/context/remote/ZippedToolkitRemoteContext.java#L227

@guychris
Copy link
Contributor

guychris commented Nov 1, 2018

I'd like to propose as a solution to this, having a .splignore file, similar to something like .gitignore, which we read to determine what files/folders should be excluded from the build archive. We could by default, if the file is not found, exclude your suggestions above. As a future enhancement, when we add functionality for a "new spl application" wizard or similar, we could pre-populate a .splignore file with what the "default" set of ignored files/folders. I feel this would be a safer approach than ignoring multiple directories that a user could potentially have need of for their build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants