Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Line Legend #58

Merged
merged 7 commits into from
Apr 10, 2017
Merged

Line Legend #58

merged 7 commits into from
Apr 10, 2017

Conversation

sabov
Copy link
Contributor

@sabov sabov commented Mar 27, 2017

Related to #52

  • highlight related line on hover
  • hide/show line on click

animation

If users want to hide legend:

ibmChart({
  data: {
    columns: [
      ['data1', 200, 300, 150, 400, 275, 360],
      ['data2', 210, 170, 240, 120, 160, 130],
      ['data3', 370, 350, 375, 340, 350, 340],
    ],
  },
  id: 'myChart',
  legend: { show: false },
});

@sabov sabov requested review from seejamescode and winslet March 27, 2017 15:49
Copy link
Collaborator

@seejamescode seejamescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Some things missing:

  • Responsiveness is lost
  • The interactive legend needs to have html buttons for keyboard accessibility
  • When the chart has a width of 1000px, the legend should have a width of 200px (according to the layout ai file). I only saw 75.55px

Copy link
Collaborator

@winslet winslet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, happy with this, thanks for the GIF - really helpful when reviewing!

@seejamescode
Copy link
Collaborator

Hey @sabov, the legend now collapses at the width it is supposed to. I do not know how to rerender the chart for the appropriate width though!

@seejamescode seejamescode merged commit b078b20 into line Apr 10, 2017
@seejamescode seejamescode deleted the line-legend branch April 10, 2017 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants