Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataValidator option for warning log as single DataFrame #438

Open
dc-almeida opened this issue Dec 17, 2024 · 1 comment
Open

Add DataValidator option for warning log as single DataFrame #438

dc-almeida opened this issue Dec 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dc-almeida
Copy link
Collaborator

Current implementation of warning log for DataValidator prints a DataFrame with flagged rows for each criterion.
Suggested by @danielhuppmann to join all warnings into a single DataFrame, ordered by warning level (descending).
Question: what is the best format for the criteria messages (which would not be joined too, I presume)?

@dc-almeida dc-almeida added the enhancement New feature or request label Dec 17, 2024
@dc-almeida dc-almeida self-assigned this Dec 17, 2024
@danielhuppmann
Copy link
Member

Good point, and after sleeping over it, I think the best solution would be to keep the log-output as is (stating the criteria, showing the failing data) but have an optional output of all failing criteria as one joined pandas.DataFrame (optionally saved to xlsx). This way, the log output is readable but if someone wants to look at the validation-results in a structured way, they have one nice dataframe.

@dc-almeida dc-almeida changed the title Change DataValidator warning log to a single DataFrame Add DataValidator option for warning log as single DataFrame Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants