Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespaces #347

Open
phackstock opened this issue May 17, 2024 · 2 comments
Open

Remove trailing whitespaces #347

phackstock opened this issue May 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@phackstock
Copy link
Contributor

It might be a good idea to remove training white spaces from the dimensions of model, scenario, variable and unit.
The fact that we currently don't do this causes some overhead in fixing these issues that could be fixed automatically.

@phackstock phackstock added the enhancement New feature or request label May 17, 2024
@phackstock phackstock self-assigned this May 17, 2024
@danielhuppmann
Copy link
Member

Nice idea, and we already do this for codelists...

def check_end_whitespace(

Question is whether that should be used on columns that are not explicitly checked as part of DataStructureDefinition.validate().

@phackstock
Copy link
Contributor Author

Good question, maybe this should be part of pyam anyway. Just as part of the reading in process stripping all the trailing whitespace of all values in all columns.
Then we wouldn't need to even think about where to add it. We could just assume that all the values inside a pyam.IamDataFrame are clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants