Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug for def safe_dist(x, timestep, amin, amax, dist_margin): #31

Open
owenliu-rdc opened this issue Oct 10, 2023 · 1 comment
Open

Bug for def safe_dist(x, timestep, amin, amax, dist_margin): #31

owenliu-rdc opened this issue Oct 10, 2023 · 1 comment
Assignees

Comments

@owenliu-rdc
Copy link

I have a question about the code inside the function safe_dist(x, timestep, amin, amax, dist_margin) in kinematic_car.py.
Should the code:

brake_min_dist = (abs(x[2]) + amax * timestep) ** 2 / (2 * amax) + dist_margin

be changed to:

brake_min_dist = (abs(x[2]) + amax * timestep) ** 2 / (2 * abs(amin)) + dist_margin

even though in the current code amax = abs(amin)

am i right?

@junzengx14
Copy link
Collaborator

@AkshayThiru Could you have a quick look on this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants