-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zygisk failing with GrapheneOS 14 build 2024031400 #129
Comments
Possibly relevant part of log - same errors are shown in non-debug log:
[...]
|
Looks like the grapheneos adjustment needs to be updated; |
Looking at the frequency of GrapheneOS builds lately, I'm pretty sure I wasn't on the previous one before updating to 2024031400, though I'm not entirely sure which one I was running. From reading the changelog, my guess would be a recent build prior to 2024030600, and that this is the build where it broke, probably due to the Android 14 QPR2 changes.
https://grapheneos.org/releases#2024030600 So once this gets fixed, hopefully there won't be major breaking changes again for a while.. |
Upstream AOSP made a change in QPR2, and GrapheneOS's prior change was maintained. The issue is that the combination of the upstream and GOS changes have a unique signature. The third "Z" in "ZZZ" whereas the older was just "ZZ". They added a boolean ("Z") parameter "mount_sysprop_overrides" to forkAndSpecialize ("fas") and specializeAppProcess ("spec"). This is the upstream Magisk change for QPR2; So all that's needed now is to alter the prior GOS patch (as I linked to above) for kitsunemask in the same manner. |
This should about do it (untested):
|
Give this a try! I have NOT tested it. Make sure to uninstall the existing magisk/kitsune application and not just patch the boot. Also rename .zip --> .apk |
Thank you @lbdroid! Tested and working for me on GrapheneOS 2024031400. |
Excellent! I've created a PR for the update to KitsuneMagisk repository here; |
Hello. Shouldn'd the PR be done here https://github.com/HuskyDG/magisk-files/pulls? |
@lbdroid. Thanks a million for this. Working on 2024032100. |
No, this repository does not contain source code, just compiled binaries. In reality, what is housed in THIS repository should be hooked up to the "releases" component of where I made the PR. |
Ahh! OK. Sorry for the noise. Thank you and HuskyDG for the time you put on your great work. |
I can also confirm that this fixes the issue as originally reported. Big thanks for your efforts, LGTM! |
I confirm this same issue in LineageOS now with a March build, so not a GrapheneOS issue |
As far as I can tell, LineageOS should be able to run on upstream Magisk version 27.0, unless they've added their own changes to zygote that create a unique signature. It is unlikely that changes for GrapheneOS would be applicable there, unless they, I think that project calls it "kanged", changes from GrapheneOS. In any case, if it doesn't work with upstream Magisk 27.0, you should file a bug report upstream here: https://github.com/topjohnwu/Magisk/issues |
kitsune is dead HuskyDG is no longer maintaining this project the telegram channel was abandoned months ago |
I'm now having a different issue with this build. After a reboot, my renamed manager app no longer shows, and has reverted to "Kitsune Mask". When trying to open that, it queries the usual "Upgrade to full Magisk to finish the setup. Download and install?", as if it had not been fully set up before. Choosing OK brings up a "Downloading Kitsune Mask" dialog, but this never finishes, it just sits there. Several tries, same result, nothing appears to be downloaded (or at least the process never completes or proceeds). I have tried flashing the boot image anew, with the same result. Android build has AFAICT not changed - it's still on 2024031400, as when I originally flashed it, and before the reboot. Anyone seeing anything similar? Or can think of why Kitsune Mask would fail to download? |
I've had this issue happen on normal Magisk. I was able to redownload the APK from GitHub (same APK you flashed) and installing it over the current one. @yitzhaq |
Indeed, after sideloading latest OTA, uninstalling the app and re-installing the APK, and re-patching (plus flashing) the updated boot image, things seem to be back to normal now. Thanks for the pointer, @probablypablito! And sorry for raising the apparently off-topic issue here. |
Thx a lot. |
Just use the APK from here instead of the regular one: #129 (comment) |
Does not work anymore latest build pixel 6 pro |
The problem with speaking in absolutes is that it can be very misleading. When you say "Does not work", people will assume that it does not work at all, when in reality, all that can really be ascertained is that it is just not working for you. For example, right here in my hand I have a Pixel 6 Pro. Same phone even, imagine that! And its running grapheneos build 2024070201, which is the latest build available as I'm typing this message, and guess what? Kitsune Mask build that I attached to this thread up above on March 19th is working just fine still. What that tells me is that you made an error installing it. Please try again. If it still doesn't work for you, provide more details. |
Just to confirm that the above attached version of Magisk on Mar 19 does still work perfectly on Pixel 7 with latest Graphene OS Build #2024070201 Thx alot ! |
I can also confirm that it's still working fine for me (OP) on a Pixel 6 Pro running 2024070201. @HuskyDG Does closing this mean that https://github.com/HuskyDG/magisk-files/blob/main/app-release.apk (and debug) now contains this patch? It's a bit unclear from the changelog. |
I installed the update and it seems to be working with GrapheneOS again. |
No need to be so aggressive. This includes the new apk posted on the github Product revision: raven MP1.0 B1 |
has anyone found a working version of LSposed that is compatible with Husky's Kitsune Magisk on GrapheneOS? |
Device: Google Pixel 6 Pro
Android version: GrapheneOS 14 build 2024031400
Magisk version name: R65C33E4F-kitsune (D)
Magisk version code: 27001
Since updating to latest OTA GrapheneOS 14 build 2024031400, Zygisk has started failing. It is enabled, but no longer activating. Both Magisk and Zygisk were working fine with R65C33E4F-kitsune when running on the previous OTA build.
I've tried dis/re-enabling Zygisk, disabling all modules, reinstalling Magisk, all to no avail. Full debug log is attached.
magisk_log_2024-03-17T14.55.55.log
Thanks in advance for looking at this, and many thanks for your efforts to keep Magisk working on GrapheneOS!
The text was updated successfully, but these errors were encountered: