-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added smoking related fields in medical_history module. Fix#1565 #1567
Conversation
…nto ac-smoking-history-Issue1565
…nto ac-smoking-history-Issue1565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some non-sensical attribute combinations that you may want to disallow. For example, smoking_pack_years must be 0 if smoking_status
is never
, or years_since_smoking_cessation
should be absent unless smoking_status
is former
.
Update smoking_status description Co-authored-by: Hannes Schmidt <[email protected]>
Thank you for you comments @hannes-ucsc . I updated the descriptions and added an if-else validation for the combinations.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Release notes
For
medical_history.json
schema:smoking_status
smoking_pack_years
years_since_smoking_cessation
smoking_history
due to overlap withsmoking_pack_years
Reviews requested
#1565