-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds DUOS id field #1551
Merged
Merged
adds DUOS id field #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncalvanese1
approved these changes
Mar 12, 2024
hannes-ucsc
approved these changes
Mar 12, 2024
ESapenaVentura
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NoopDog
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
amnonkhen
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550
Rationale
data_use_restriction = GRU
orGRU-NCU
)data_use_restriction = NRES
)DUOS_id
should be forbidden. This way if a project is erroneously marked as open access we can’t export it with a DUOS id.Implementation:
DUOS_id
is disallowed for open access projects it should be conditionally defined fordata_use_restriction = GRU
orGRU-NCU
.This is not possible because
additionalProperties
is set to false, which means that any property not defined in the main property section will fail validation. RemovingadditionalProperties : false
is not an option because then any undeclared property would also be valid.In draft 9 by the keyword
unevaluatedProperties
allows to define properties in subschemas, but we are using draft7 so this option is not available to us right now.The compromise I made is to require the length of the
DUOS_id
to be 0, so that if thedata_use_restriction
isn’t set correctly the schema will not validate.Release notes
For type/project/project.json schema:
DUOS_id
field