Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gene_annotation_version field in analysis_protocol.json. Fixes #1543 #1544

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

arschat
Copy link
Collaborator

@arschat arschat commented Jan 12, 2024

Release notes

For analysis_protocol.json schema:

  • Added gene_annotation_version optional field

Why are these changes needed?

This field is needed to record the specific Ensembl release version accession number or NCBI RefSeq assembly version.
Is one of the upcoming Tier 1 metadata proposed from HCA Integration Teams & Bionetworks

Reviews requested

  • Need 5 Reviewers to approve because this is a minor update

Copy link
Collaborator

@ESapenaVentura ESapenaVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@amnonkhen amnonkhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor question

json_schema/type/protocol/analysis/analysis_protocol.json Outdated Show resolved Hide resolved
@arschat arschat merged commit f658e1f into staging Feb 5, 2024
3 of 5 checks passed
@arschat arschat deleted the ac-gene-annotation-version-Issue1543 branch February 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants