Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed timecourse from types and added to biomaterial core. Fixes #1511 #1529

Merged
merged 4 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/jsonBrowser/core.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ supplementary_files | A list of filenames of biomaterial-level supplementary fil
biosamples_accession | A BioSamples accession. | string | no | | BioSamples accession | | SAMN00000000
insdc_sample_accession | An International Nucleotide Sequence Database Collaboration (INSDC) sample accession. | string | no | | INSDC sample accession | | SRS0000000
HDBR_accession | A Human Developmental Biology Resource (HDBR) sample accession. | string | no | | HDBR accession | | 34526; 14758, 2, liver
timecourse | Information relating to a timecourse associated with this biomaterial. | object | no | [See module timecourse](module.md#timecourse) | Timecourse | |

## Process core<a name='Process core'></a>
_Information relevant to how a biomaterial or file was converted into another biomaterial or file._
Expand Down
3 changes: 0 additions & 3 deletions docs/jsonBrowser/type.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ genus_species | The scientific binomial name for the species of the suspension.
selected_cell_types | The cell type(s) selected to be present in the suspension. | array | no | [See module cell_type_ontology](module.md#cell-type-ontology) | Selected cell type(s) | |
estimated_cell_count | Estimated number of cells in the suspension. | integer | no | | Estimated cell count | | 1; 2100
plate_based_sequencing | Fields specific for plate-based sequencing experiments. | object | no | [See module plate_based_sequencing](module.md#plate-based-sequencing) | Plate-based sequencing | |
timecourse | Information relating to a timecourse associated with this cell suspension. | object | no | [See module timecourse](module.md#timecourse) | Timecourse | |

## Cell line
_Information about the cell line or cell culture biomaterial._
Expand Down Expand Up @@ -390,7 +389,6 @@ date_established | Date when the cell line was established. | string | no | | D
disease | Short description of any disease association to the cell type. | object | no | [See module disease_ontology](module.md#disease-ontology) | Disease | |
genus_species | The scientific binomial name for the species of the cell line. | array | no | [See module species_ontology](module.md#species-ontology) | Genus species | |
publication | A publication that cites the cell line creation. | object | no | [See module publication](module.md#publication) | Publication | |
timecourse | Information relating to a timecourse associated with this cell line. | object | no | [See module timecourse](module.md#timecourse) | Timecourse | |

## Imaged specimen
_Information about a tissue specimen after it has been sectioned and prepared for imaging._
Expand Down Expand Up @@ -434,7 +432,6 @@ height | Height of organism in Height unit. | string | no | | Height | | 160;
height_unit | The unit in which Height is expressed. | object | no | [See module length_unit_ontology](module.md#length-unit-ontology) | Height unit | |
weight | Weight of organism in Weight unit. | string | no | | Weight | | 60; 40-60
weight_unit | The unit in which Weight is expressed. | object | no | [See module mass_unit_ontology](module.md#mass-unit-ontology) | Weight unit | |
timecourse | Information relating to a timecourse associated with this biomaterial. | object | no | [See module timecourse](module.md#timecourse) | Timecourse | |

## Organoid
_Information about an organoid biomaterial._
Expand Down
6 changes: 6 additions & 0 deletions json_schema/core/biomaterial/biomaterial_core.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@
"user_friendly": "HDBR accession",
"example": "34526; 14758, 2, liver",
"guidelines": "Enter accession if sample has been obtained from the Human Developmental Biology Resource (HDBR)."
},
"timecourse": {
"description": "Information relating to a timecourse associated with this biomaterial.",
"type": "object",
"$ref": "module/biomaterial/timecourse.json",
"user_friendly": "Timecourse"
}
}
}
27 changes: 27 additions & 0 deletions json_schema/property_migrations.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
{
"migrations": [
{
"source_schema": "cell_line",
"property": "timecourse",
"target_schema": "cell_line",
"replaced_by": "biomaterial_core.timecourse",
"effective_from": "16.0.0",
"reason": "Timecourse module has been moved to biomaterial core",
"type": "moved property"
},
{
"source_schema": "donor_organism",
"property": "timecourse",
"target_schema": "donor_organism",
"replaced_by": "biomaterial_core.timecourse",
"effective_from": "16.0.0",
"reason": "Timecourse module has been moved to biomaterial core",
"type": "moved property"
},
{
"source_schema": "cell_suspension",
"property": "timecourse",
"target_schema": "cell_suspension",
"replaced_by": "biomaterial_core.timecourse",
"effective_from": "14.0.0",
"reason": "Timecourse module has been moved to biomaterial core",
"type": "moved property"
},
{
"source_schema": "analysis_file",
"property": "genome_assembly_version",
Expand Down
6 changes: 0 additions & 6 deletions json_schema/type/biomaterial/cell_line.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,6 @@
"type": "object",
"$ref": "module/project/publication.json",
"user_friendly": "Publication"
},
"timecourse": {
"description": "Information relating to a timecourse associated with this cell line.",
"type": "object",
"$ref": "module/biomaterial/timecourse.json",
"user_friendly": "Timecourse"
}
}
}
6 changes: 0 additions & 6 deletions json_schema/type/biomaterial/cell_suspension.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@
"type": "object",
"$ref": "module/process/sequencing/plate_based_sequencing.json",
"user_friendly": "Plate-based sequencing"
},
"timecourse": {
"description": "Information relating to a timecourse associated with this cell suspension.",
"type": "object",
"$ref": "module/biomaterial/timecourse.json",
"user_friendly": "Timecourse"
}
}
}
6 changes: 0 additions & 6 deletions json_schema/type/biomaterial/donor_organism.json
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,6 @@
"type": "object",
"$ref": "module/ontology/mass_unit_ontology.json",
"user_friendly": "Weight unit"
},
"timecourse": {
"description": "Information relating to a timecourse associated with this biomaterial.",
"type": "object",
"$ref": "module/biomaterial/timecourse.json",
"user_friendly": "Timecourse"
}
}
}
4 changes: 4 additions & 0 deletions json_schema/update_log.csv
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
Schema,Change type,Change message,Version,Date
core/biomaterial/biomaterial_core,minor,Added timecourse module. Fixes #1511,,
type/biomaterial.donor_organism,major,Removed timecourse module.,,
type/biomaterial.cell_suspension,major,Removed timecourse module.,,
type/biomaterial.cell_line,major,Removed timecourse module.,,