Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing the base exception class to AnnouncementError #349

Open
Rixxan opened this issue Jun 21, 2023 · 0 comments
Open

Passing the base exception class to AnnouncementError #349

Rixxan opened this issue Jun 21, 2023 · 0 comments
Labels
code review help wanted Extra attention is needed
Milestone
2.0

Comments

@Rixxan
Copy link
Member

Rixxan commented Jun 21, 2023

Per review by @theunkn0wn1:

passing the base exception class to AnnouncementError is sus.

This should be investigated and audited to see if this is intended behavior or if there's a better way to do it.

Originally posted by @theunkn0wn1 in #346 (comment)
@Rixxan Rixxan added help wanted Extra attention is needed code review labels Jun 21, 2023
@Rixxan Rixxan added this to the 2.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review help wanted Extra attention is needed
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Rixxan