Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fire !welcome once per named client #122

Open
Rixxan opened this issue Jan 1, 2022 · 1 comment
Open

Only fire !welcome once per named client #122

Rixxan opened this issue Jan 1, 2022 · 1 comment
Milestone

Comments

@Rixxan
Copy link
Member

Rixxan commented Jan 1, 2022

A cache system (similar to lookups) should be introduced so that the !welcome command (if args/client name is given) is only fired once per client. This will reduce spam in channel as well as confusion as to who is doing what.

Suggested format:

!welcome <--force> (clientName)

if no args, simply fire the !welcome without a name, thus avoiding pinging the user. This will probably use parts of https://gitlab.com/hull-seals/code/irc/halpybot/-/blob/develop/src/packages/edsm/edsm.py#L94-L100 as well as command masking from https://gitlab.com/hull-seals/code/irc/halpybot/-/blob/develop/src/commands/caseutils.py#L27

recommend also including a check for -LL where LL is a two-letter language code

@Rixxan
Copy link
Member Author

Rixxan commented Jan 1, 2022

This isn't a very common issue, and is questionable if we'll even want to/need to use this.

Worth discussion at a later time (post 1.5 launch)

@Rixxan Rixxan added this to SACM Jan 12, 2023
@Rixxan Rixxan removed this from SACM Jan 12, 2023
@Rixxan Rixxan added this to the 2.0 milestone Jan 12, 2023
@Rixxan Rixxan added this to SACM Feb 26, 2023
@Rixxan Rixxan added the sacm label Feb 26, 2023
@Rixxan Rixxan moved this to Todo in SACM Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant