Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images for multiple platforms #169

Merged
merged 51 commits into from
Jan 3, 2024
Merged

Conversation

ProgramComputer
Copy link

@ProgramComputer ProgramComputer commented Dec 29, 2023

As discussed #141. Serve lwt at /lwt to be consistent with docs.

If pulled, HugoFara/lwt-docker-installer#4 would too.

ProgramComputer and others added 22 commits December 28, 2023 20:46
* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

---------

Co-authored-by: HugoFara <[email protected]>
@ProgramComputer ProgramComputer deleted the patch-6 branch December 29, 2023 17:01
@ProgramComputer ProgramComputer restored the patch-6 branch December 29, 2023 17:01
@HugoFara HugoFara added enhancement Develop an existing feature docker Anything related to Docker labels Jan 1, 2024
HugoFara added a commit that referenced this pull request Jan 3, 2024
Copy link
Owner

@HugoFara HugoFara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I will need you to give me more explanations, as you are modifying an important action. I detailed the lines that give me trouble. Did you try your package anywhere so that I can see a successful run?

.github/workflows/docker-image.yml Show resolved Hide resolved
.github/workflows/docker-image.yml Outdated Show resolved Hide resolved
.github/workflows/docker-image.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ProgramComputer
Copy link
Author

ProgramComputer commented Jan 3, 2024

@HugoFara

Hi, I will need you to give me more explanations, as you are modifying an important action. I detailed the lines that give me trouble. Did you try your package anywhere so that I can see a successful run?

Ran a test release. You can see a history of runs for the container. Tested permissions on it.

@HugoFara HugoFara merged commit 57b0d16 into HugoFara:dev Jan 3, 2024
HugoFara added a commit that referenced this pull request Jan 3, 2024
@ProgramComputer ProgramComputer deleted the patch-6 branch January 3, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Anything related to Docker enhancement Develop an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants