Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer theming options #115

Open
HenryWales opened this issue Apr 27, 2023 · 1 comment
Open

Clearer theming options #115

HenryWales opened this issue Apr 27, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement Develop an existing feature

Comments

@HenryWales
Copy link

HenryWales commented Apr 27, 2023

I guess the theme feature is meant to allow total overhauls.

But the existing themes seem to only change one thing or two, and there is no info in the UI at all on what is changed

Testing I noticed these changes:

Default-mod: The only thing I noticed is that instead of an overflowing "word." being sent to the next line, it splits the word from the punctuation sign and only overflows the punctuation sign if possible. Maybe useful for some languages, strange with an european one.
Lingocracy: Different style of word highlighting, much more discrete. Same breaking difference as default-mod compared to default.
Lingocracy: dark mode of the above
Night Mode: dark mode of default-mod?
White Night: night mode, but highlighted words are also white
Chaosarium light: normal breaking rules, different style of highlighting compared to default, different "word action box" theme.

Full-theme support is also good, but I propose to split some theme options:

  • Light mode or Dark mode
  • Highlighting style
  • Text breaking rules
@HugoFara HugoFara added enhancement Develop an existing feature documentation Improvements or additions to documentation labels Apr 28, 2023
@HugoFara
Copy link
Owner

Hi! That's an interesting suggestion! I'm not the one who implemented themes, so I did not really focused on this issue until now.

I guess I can add some words in the documentation, I may add a more detailed explanation in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Develop an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants