#3 Add linting

package.json

@@ -4,10 +4,10 @@
   "description": "Convenience functions for the Puppeteer",
   "main": "lib/index.js",
   "scripts": {
-    "build": "tsc",
+    "build": "npm run lint && tsc",
     "test": "npm run build && jest /tests",
-    "postinstall": "node tests/setup.js"
-    "lint": "tslint -t codeFrame 'src/**/*.ts'"
+    "postinstall": "node tests/setup.js",
+    "lint": "tslint --project tsconfig.json -t codeFrame 'src/**/*.ts'"
   },
   "repository": {
     "type": "git",

src/api/miscellaneous.ts

@@ -2,7 +2,8 @@
  *
  * This file represents the miscellaneous API. It exposes functions that don't fit under a particular category.
  *
- **/
+ */
+
 import {serializeFunctionWithArgs} from '../external/serialization-utils';
 import {Page} from "puppeteer";
 

src/api/retrieval.ts

@@ -2,7 +2,7 @@
  *
  * This file represents the retrieval API. It exposes convenience functions for getting properties/values/state from the UI.
  *
- **/
+ */
 
 import {Page} from "puppeteer";
 

src/api/waits.ts

@@ -2,7 +2,7 @@
  *
  * This file represents the waits API. It exposes useful polling functions for particular resources or selectors
  *
- **/
+ */
 
 import {serializeFunctionWithArgs} from '../external/serialization-utils';
 import {Request, Page} from "puppeteer";
@@ -26,7 +26,7 @@ const pollFor = ({checkFn, interval, timeout, timeoutMsg} : {checkFn: () => Prom
 
 const isSuccessfulResponse = (request: Request) : boolean => {
     const response = request.response && request.response();
-    return response && (response.status() === 200 || response.status() === 304);
+    return response && (response.status() === 200 || response.status() === 304) || false;
 };
 
 export function init (puppeteerPage: Page, requests, defaultTimeout) : object {
@@ -35,7 +35,7 @@ export function init (puppeteerPage: Page, requests, defaultTimeout) : object {
          * Wait for a resource request to be responded to
          * @param {string} resource - The URL of the resource (or a substring of it)
          * @param {number] [timeout=defaultTimeout] - Timeout for the check
-     */
+         */
         waitForResource (resource: string, timeout : number = defaultTimeout) {
             return new Promise((resolve, reject) => {
 
@@ -49,7 +49,7 @@ export function init (puppeteerPage: Page, requests, defaultTimeout) : object {
                 } else {
                     pollFor({
                         checkFn: async () => {
-                            return await resourceRequestHasResponded();
+                            return resourceRequestHasResponded();
                         },
                         interval: 100,
                         timeout: timeout,
@@ -62,7 +62,7 @@ export function init (puppeteerPage: Page, requests, defaultTimeout) : object {
          * Wait for a specific number of web fonts to be loaded and ready on the page
          * @param {number} count - The number of web fonts to expect
          * @param {number] [timeout=defaultTimeout] - Timeout for the check
-     */
+         */
         async waitForLoadedWebFontCountToBe(count: number, timeout : number = defaultTimeout) {
             let hasInjectedWebFontsAllLoadedFunction = false;
 
@@ -82,8 +82,13 @@ export function init (puppeteerPage: Page, requests, defaultTimeout) : object {
                         });
                     } else {
                         await puppeteerPage.evaluate(() => {
-                            (async function() {
-                                window.__webFontsAllLoaded = await document.fonts.ready;
+                            return (async function() {
+                                try {
+                                    window.__webFontsAllLoaded = await document.fonts.ready;
+                                } catch (e) {
+                                    return false;
+                                }
+
                             })();
                         });
 

src/external/serialization-utils.ts

@@ -10,7 +10,7 @@
  * Copyright (C) 2011 James Roe <[email protected]>
  * Copyright (C) 2011 execjosh, http://execjosh.blogspot.com
  * Copyright (C) 2012 James M. Greene <[email protected]>
-**/
+ */
 
 // Source: https://github.com/ariya/phantomjs/blob/master/src/modules/webpage.js#L205
 const detectType = (value: any) => {
@@ -33,7 +33,11 @@ const detectType = (value: any) => {
 
 // Source: https://github.com/ariya/phantomjs/blob/master/src/modules/webpage.js#L167
 const quoteString = (str: string) => {
-    let c, i, l = str.length, o = '"';
+    let c;
+    let i;
+    let l = str.length;
+    let o = '"';
+
     for (i = 0; i < l; i += 1) {
         c = str.charAt(i);
         if (c >= ' ') {
@@ -80,14 +84,14 @@ export function serializeFunctionWithArgs(fn: any, ...args: any[]) {
         let argType = detectType(arg);
 
         switch (argType) {
-            case 'object':      //< for type "object"
-            case 'array':       //< for type "array"
+            case 'object':      // < for type "object"
+            case 'array':       // < for type "array"
                 str += JSON.stringify(arg) + ',';
                 break;
-            case 'date':        //< for type "date"
+            case 'date':        // < for type "date"
                 str += 'new Date(' + JSON.stringify(arg) + '),';
                 break;
-            case 'string':      //< for type "string"
+            case 'string':      // < for type "string"
                 str += quoteString(arg) + ',';
                 break;
             default:            // for types: "null", "number", "function", "regexp", "undefined"

tsconfig.json

@@ -5,7 +5,8 @@
     "lib": ["es2015", "es2016", "es2017", "dom"],
     "outDir": "lib",
     "sourceMap": true,
-    "target": "es2015"
+    "target": "es2015",
+    "strictNullChecks": true
   },
   "include": [
     "src",