Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Ignore antialiasing gives false positive #67

Open
NiGhTTraX opened this issue Aug 25, 2014 · 1 comment
Open

Ignore antialiasing gives false positive #67

NiGhTTraX opened this issue Aug 25, 2014 · 1 comment
Labels

Comments

@NiGhTTraX
Copy link
Contributor

Diffing two images with ignore antialiasing turned on gives me a false positive (the diff is blank). Images are below. Diffing them with ignore nothing or ignore colors produces the expected result.

Image 1

drag

Image 2

drag2

Diff with ignore antialiasing

image

/cc @jamescryer

@jamescryer jamescryer added the bug label Aug 26, 2014
@jamescryer
Copy link

Colour difference tolerance is higher for the 'ignore Anti-aliasing' mode.

The quick solution to this would be to expose the tolerance settings for update https://github.com/Huddle/Resemble.js/blob/master/resemble.js#L527

Though without that tolerance the anti-aliasing detection probably won't work so well, at least with grey-scale vs color hue anti-aliasing.

The correct solution would be to use a better anti-aliasing detection algorithm. This would take some investigation. I'll have a think about it.

If you're not running the tests on different machines then it's probably safe not to use 'ignore Anti-aliasing' mode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants