Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds scripts for usual steps #359

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

DougReeder
Copy link
Contributor

@DougReeder DougReeder commented Sep 10, 2024

This makes it easy to perform steps from an IDE.

@DougReeder
Copy link
Contributor Author

The apply script applies hcce.yaml and monitors until all deployments are ready.

Copy link
Contributor

@Exairnous Exairnous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these seem to be nice convenience commands, but I'm not sure why this should affect IDEs at all. Can you expand on that?

As to the scripts themselves.
We have had issues in the past with running terminal commands via the asynchronous Node functions and they are harder to read, so the synchronous versions should be used instead.

The new commands also need documentation in the readme.

@DougReeder
Copy link
Contributor Author

Without these scripts, one needs a terminal window open to enter the kubectl commands. With the new scripts, in an IDE, one can click on the scripts to run them, and not keep a terminal window open.

The scripts work equally well when run from the command line.

Copy link
Contributor

@Exairnous Exairnous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. This looks good now. Merging.

@Exairnous Exairnous merged commit a6eb0b8 into Hubs-Foundation:master Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants