Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with _pid and router._producers causing worker idling and errors #53

Open
klee1611 opened this issue Jan 17, 2024 · 0 comments · May be fixed by #54
Open

Issues with _pid and router._producers causing worker idling and errors #53

klee1611 opened this issue Jan 17, 2024 · 0 comments · May be fixed by #54

Comments

@klee1611
Copy link

Description:
I have encountered a couple of issues in the current codebase that are impacting the proper functioning of the application. I am planning to create a Pull Request to address these concerns, and I wanted to document them here for better visibility and discussion.

  1. The _pids of workers are currently undefined, preventing the proper distribution of routers across different workers. As a result, all workers except one are idled. This is a critical issue as it significantly impacts the efficiency of the system.

  2. After adding _pids to workers, when piping producers to routers, the expression router._producers.has(producerId) is throwing errors. This error disrupts the expected flow of data distribution and must be addressed to ensure the smooth operation of the application.

Expected Behavior:

  1. Workers should have valid _pids to enable proper distribution of routers.
  2. Piping producers to routers should not result in errors related to router._producers.has(producerId).

I will be working on creating a Pull Request to fix these issues.

Note to Reviewers:
I am in the process of creating a Pull Request to address these issues. Your insights and guidance during the review process will be invaluable.

Thank you!

klee1611 added a commit to klee1611/dialog that referenced this issue Jan 17, 2024
@klee1611 klee1611 linked a pull request Jan 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant