You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
I have encountered a couple of issues in the current codebase that are impacting the proper functioning of the application. I am planning to create a Pull Request to address these concerns, and I wanted to document them here for better visibility and discussion.
The _pids of workers are currently undefined, preventing the proper distribution of routers across different workers. As a result, all workers except one are idled. This is a critical issue as it significantly impacts the efficiency of the system.
After adding _pids to workers, when piping producers to routers, the expression router._producers.has(producerId) is throwing errors. This error disrupts the expected flow of data distribution and must be addressed to ensure the smooth operation of the application.
Expected Behavior:
Workers should have valid _pids to enable proper distribution of routers.
Piping producers to routers should not result in errors related to router._producers.has(producerId).
I will be working on creating a Pull Request to fix these issues.
Note to Reviewers:
I am in the process of creating a Pull Request to address these issues. Your insights and guidance during the review process will be invaluable.
Thank you!
The text was updated successfully, but these errors were encountered:
klee1611
added a commit
to klee1611/dialog
that referenced
this issue
Jan 17, 2024
Description:
I have encountered a couple of issues in the current codebase that are impacting the proper functioning of the application. I am planning to create a Pull Request to address these concerns, and I wanted to document them here for better visibility and discussion.
The
_pid
s of workers are currentlyundefined
, preventing the proper distribution of routers across different workers. As a result, all workers except one are idled. This is a critical issue as it significantly impacts the efficiency of the system.After adding
_pid
s to workers, when piping producers to routers, the expressionrouter._producers.has(producerId)
is throwing errors. This error disrupts the expected flow of data distribution and must be addressed to ensure the smooth operation of the application.Expected Behavior:
_pid
s to enable proper distribution of routers.router._producers.has(producerId)
.I will be working on creating a Pull Request to fix these issues.
Note to Reviewers:
I am in the process of creating a Pull Request to address these issues. Your insights and guidance during the review process will be invaluable.
Thank you!
The text was updated successfully, but these errors were encountered: