Fix potentially adding a duplicate component when migrating the grabbable component #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scene grabbables support was reverted (Hubs-Foundation/hubs#6515) in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit restores the scene grabbables and physics support (along with fixes/improvements that were added to it in the main Blender add-on) to the behavior graphs Blender add-on to allow the functionality to be used with the Hubs Client's addons branch and its behavior graphs add-on. A corresponding commit to the main Blender add-on removes support for scene grabbables/physics in the main Blender add-on so it maintains compatibility with the current Hubs Client.
…able component Prevents an extra Networked Transform component from being added to the host during the migration of the grabbable component if a Networked Transform component is somehow already present on the host. This shouldn't generally be needed, but a duplicate Networked Transform component was added during the migration of an old blend file and adding a guard to prevent duplicates doesn't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #27
Prevents an extra Networked Transform component from being added to the host during the migration of the grabbable component if a Networked Transform component is somehow already present on the host.
This shouldn't generally be needed, but a duplicate Networked Transform component was added during the migration of an old blend file and adding a guard to prevent duplicates doesn't hurt.