Assign extensions if the didn't exist already #25
Conversation
There was a problem hiding this comment.
Thanks!
I'm pretty sure nothing else references get_hubs_ext so I think you can remove the function definition as well. Also, I don't think you need the existed property/check. I'm pretty sure you can assign the new dictionary immediately after defining it and then everything would work as if it were there all along and there wouldn't be the need for the extra variable/check.
However, what I've said above shouldn't affect any functional differences (they would just make the code nicer, IMO), so I'm approving these changes.
| if type(gltf2_object) is tuple: | ||
| gltf2_object[0].extensions = extensions | ||
| else: | ||
| gltf2_object.extensions = extensions |
There was a problem hiding this comment.
I think this is fine, but it seems kind of hard to reason about to me.
Are you sure this shouldn't be up under the if extensions is None: block?
We weren't assigning the extensoins back to the gltf object in case the map didn't exist