Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset, TargetOffset and other options are not passed on the Tether #166

Open
talbet opened this issue Dec 16, 2016 · 0 comments
Open

Offset, TargetOffset and other options are not passed on the Tether #166

talbet opened this issue Dec 16, 2016 · 0 comments

Comments

@talbet
Copy link

talbet commented Dec 16, 2016

I cannot get the 'offset' option, which is documented in Tether, to work while using Drop. It looks like the Drop constructor calls the Tether constructor with a set of default options that are incorrectly merged with the parameters passed to the Drop constructor.

The Tether constructor is called here

      if (this.options.tetherOptions !== false) {
        this.tether = new Tether(extend({}, opts, this.options.tetherOptions));
      }

But this.options.tetherOptions will always be an empty object (it is initialised, but never referenced anywhere else in the code).

It looks like it should be merged with this.options instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant