Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore ways to tie Lang Switcher V1 into theme settings #485

Open
2 tasks done
jazzyclimber opened this issue Jun 27, 2023 · 0 comments
Open
2 tasks done

Explore ways to tie Lang Switcher V1 into theme settings #485

jazzyclimber opened this issue Jun 27, 2023 · 0 comments

Comments

@jazzyclimber
Copy link
Contributor

We have recently added support for language switcher v1 into the theme (#484). Most of the module settings for that were added directly into the template. This is how it should be setup, however, many of these values can likely be pulled from theme settings.

In order to better connect it all let's explore some ways that we can connect those various settings to theme settings so there is less that it is more tightly integrated into the theme itself.

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant