Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add ability to mark a Label required #137

Closed
jackcmeyer opened this issue Dec 4, 2019 · 3 comments
Closed

Add ability to mark a Label required #137

jackcmeyer opened this issue Dec 4, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed released
Milestone

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Dec 4, 2019

🚀 Feature Proposal

Add an ability to mark a label required.

A new prop called isRequired should be added to the label component. When true, there should be a red * added on the right hand side of the label. When false, no red star should be shown.

Screen readers should be able to read the red star with some sort of alternative text so users using assistive technology can understand the star.

Motivation

Marking required fields in a form.

Example

Please provide an example for how this feature would be used.
image

related to #65

@jackcmeyer jackcmeyer added the enhancement New feature or request label Dec 4, 2019
@jackcmeyer jackcmeyer added this to the v1.0.0 milestone Dec 4, 2019
@jackcmeyer jackcmeyer added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 4, 2019
@varshannagarajan
Copy link

Hi I would like to work on this. If that's ok?

@ocBruno
Copy link
Contributor

ocBruno commented Dec 5, 2019

Hi I would like to work on this. If that's ok?

Hey I've almost finished this one and suggested a custom title message for the acessibility which i'm not sure will be approved. Soon I will create a pull request for this feature if you want to check it out and suggest any improvements or changes!

@fox1t fox1t closed this as completed in 5ed1942 Dec 30, 2019
ghost pushed a commit that referenced this issue Dec 30, 2019
# [0.24.0](v0.23.0...v0.24.0) (2019-12-30)

### Bug Fixes

* **label:** fix-label-component-comment ([e3f3268](e3f3268)), closes [#141](#141)
* **label:** remove unrelated commits ([0e251a2](0e251a2)), closes [#141](#141)
* fix-label-default-props ([b991f56](b991f56)), closes [#141](#141)
* fix-label-doc ([cffdf9f](cffdf9f)), closes [#141](#141)

### Features

* feat(components): add Label isRequired property and other options ([dc201c3](dc201c3)), closes [#137](#137)
@ghost
Copy link

ghost commented Dec 30, 2019

🎉 This issue has been resolved in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Development

No branches or pull requests

3 participants