Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moire Effect #74

Open
Hopson97 opened this issue Jan 13, 2020 · 4 comments
Open

Moire Effect #74

Hopson97 opened this issue Jan 13, 2020 · 4 comments
Labels
Bug Reporting or fixing something that is not working as intended Rendering Bugs/Features relating to rendering

Comments

@Hopson97
Copy link
Owner

Bug Name

Moire Effect

Describe the bug

When looking in the distant, sometimes circles can appear on the terrain

To Reproduce

Just looks at things far away

Screenshots

Screenshot_20200113_065323

Desktop (please complete the following information):

  • OS: Windows 10, Ubuntu LTS

Additional context

Possibly caused by wacky texture parameters on the Texture Array object (found in src/client/gl/textures.cpp)

@Hopson97 Hopson97 added the Bug Reporting or fixing something that is not working as intended label Jan 13, 2020
@UglySwedishFish
Copy link

This is not a bug per se, but an artifact that is caused by geometry aliasing. There is nothing you could do in the texture tweaking to solve this.

@UglySwedishFish
Copy link

As an additional pointer to this, if you really want to get rid of it I could attempt a rewrite of the entire rendering pipeline. But I don't think you're going to like the additional work you're going to have to do when you want to add additional simple things (like waving plants)

@redinator2000
Copy link

Possible ways to dodge the issue:

  • use a different set of simpler textures for blocks >150 blocks away (probably will look worse)
  • use something like minecraft optifine's connected textures, use the top all-green texture on the side of grass blocks when there is another grass block 1 unit to the side and 1 unit down
    image
  • for steep/high altitude terrain, generate a simpler textured block on the surface, like stone

@rehwinkel
Copy link
Contributor

I believe simple MSAA can fix this issue.

@Hopson97 Hopson97 added the Rendering Bugs/Features relating to rendering label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reporting or fixing something that is not working as intended Rendering Bugs/Features relating to rendering
Projects
None yet
Development

No branches or pull requests

4 participants