Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] MoreInfo proto (#3) #4

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[FEAT] MoreInfo proto (#3) #4

merged 2 commits into from
Jul 21, 2023

Conversation

jh2ee
Copy link
Member

@jh2ee jh2ee commented Jul 19, 2023

관련 이슈

🔒 Closes

#3

작업내용

  • 작업 내용
  • MoreInfo 뷰 구현
  • 뷰 내의 InfoCard 컴포넌트 구현 (이미지 파일 없음)
  • styled-component 통해 CSS 최소한 구현 ( 중간 보고서용, 이후 수정 예정)
작업 전 작업 후
image

추후 진행할 사항

반응형 구현, CSS 수정 보완(컨벤션 작성 후)

리뷰포인트

Reference

Checklist

  • 필요없는 주석, 프린트문 제거했는지 확인
  • 컨벤션 지켰는지 확인

@jh2ee jh2ee self-assigned this Jul 19, 2023
xlooslo
xlooslo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@xlooslo xlooslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용

@jh2ee jh2ee merged commit acb36e6 into develop Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlooslo xlooslo xlooslo approved these changes

@ju1e3718 ju1e3718 Awaiting requested review from ju1e3718

@oonyongs oonyongs Awaiting requested review from oonyongs

@hye-inA hye-inA Awaiting requested review from hye-inA

Assignees

@jh2ee jh2ee

Labels
FEAT UI 재혁
Projects
Job1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jh2ee @xlooslo