Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr
.This release has support for
and requiresGo 1.18 to build.The previous release can already be built using Go 1.18, but fails when invoking some linters that are broken with Go 1.18. The new release fixes some of the linters and disables many other linters that fail.
See golangci/golangci-lint#2438 and golangci/golangci-lint#2649
This creates a bit of a bootstrapping problem for Brew, #91369 won't succeed until golangci-lint (amongst all the other failed packages) is fixed, and golangci-lint can't be fixed until Go 1.18 lands.It might be necessary to create another PR pinning it to
[email protected]
in the meantime, or disable the tests.Edit: Judging from the green CI and local testing, it looks like 1.45.0 can still be built using Go 1.17 despite the go directive in
go.mod
stating 1.18 as minimum version; it also appears to work fine as long as the linted code is <1.18.So it should be fine merging this right away to remove another blocker for Go 1.18.
Test output from #91369 regarding golangci-lint