Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virgil: depend on x86_64 #96009

Closed
wants to merge 1 commit into from
Closed

virgil: depend on x86_64 #96009

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 28, 2022

See VirgilSecurity/virgil-cli#58

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Feb 28, 2022
@Wink35
Copy link

Wink35 commented Feb 28, 2022

R

@Bo98 Bo98 added the CI-no-bottles Merge without publishing bottles label Mar 1, 2022
@cho-m
Copy link
Member

cho-m commented Mar 1, 2022

Looks like they compile their C library and package it for various OS/hardware: https://github.com/VirgilSecurity/virgil-sdk-go/tree/master/crypto/wrapper/pkg

They did add support for M1 in C library (https://github.com/VirgilSecurity/virgil-crypto-c/releases/tag/v0.16.0) but still need to update their wrappers/Go code & cut a new release.

Not sure if we can build the C library and link to it ourselves (and hard to tell if there are any other possible issues that need to be addressed to make code ARM-compatible).


EDIT: It is possible to build virgil-crypto-c on M1 and then link libraries to virgil via CGO_LDFLAGS. Whether this will cause issues though is hard to tell without testing since upstream builds specific versions of static libraries.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this, and we can always fix it later

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@stefanb stefanb mentioned this pull request Mar 1, 2022
@iMichka iMichka deleted the virgil branch March 1, 2022 20:28
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants